Merge pull request #30029 from tssurya/do-not-expect-remote-node-bgp-routes

OCPBUGS-56506: Don't check for remote node subnet BGP routes

Author: openshift-merge-bot[bot]

test/extended/networking/route_advertisements.go

@@ -1159,8 +1159,6 @@ spec:
 // verifyLearnedBgpRoutesForNode encapsulates the verification of learned BGP routes for a node.
 func verifyLearnedBgpRoutesForNode(oc *exutil.CLI, nodeName string, network string) {
 	var lastErr error
-	nodeSubnets, err := getNodeSubnets(oc, network)
-	o.Expect(err).NotTo(o.HaveOccurred())
 
 	g.By(fmt.Sprintf("Checking routes for node %s in network %s", nodeName, network))
 	o.Eventually(func() bool {
@@ -1174,12 +1172,6 @@ func verifyLearnedBgpRoutesForNode(oc *exutil.CLI, nodeName string, network stri
 			lastErr = fmt.Errorf("missing external routes")
 			return false
 		}
-
-		if !verifyNodeSubnetRoutes(nodeName, nodeSubnets, bgpV4Routes, bgpV6Routes) {
-			lastErr = fmt.Errorf("missing node subnet routes")
-			return false
-		}
-
 		return true
 	}, 3*timeOut, interval).Should(o.BeTrue(), func() string {
 		return fmt.Sprintf("Route verification failed for node %s: %v", nodeName, lastErr)
@@ -1198,28 +1190,6 @@ func verifyExternalRoutes(v4Routes, v6Routes map[string]string) bool {
 	return true
 }
 
-func verifyNodeSubnetRoutes(nodeName string, nodeSubnets map[string][]net.IPNet, v4Routes, v6Routes map[string]string) bool {
-	for node, subnets := range nodeSubnets {
-		if node == nodeName {
-			continue
-		}
-		for _, subnet := range subnets {
-			if subnet.IP.To4() != nil {
-				if _, ok := v4Routes[subnet.String()]; !ok {
-					framework.Logf("Missing v4 route for node %s subnet %s", node, subnet.String())
-					return false
-				}
-			} else {
-				if _, ok := v6Routes[subnet.String()]; !ok {
-					framework.Logf("Missing v6 route for node %s subnet %s", node, subnet.String())
-					return false
-				}
-			}
-		}
-	}
-	return true
-}
-
 func checkExternalResponse(oc *exutil.CLI, proberPod *corev1.Pod, podIP, ExternalIP string, serverPort int, packetSnifferDaemonSet *v1.DaemonSet, targetProtocol string) {
 	g.By("Sending request from the external host to the PodIPs")
 	request := fmt.Sprintf("dial?protocol=http&host=%s&port=%d&request=clientip", podIP, serverPort)