Skip to content

Commit 53396a5

Browse files
Merge pull request #28329 from eggfoobar/fix-adm-release-payload
fix: wrap InitializeReleasePullSpecString in check for HasNoOptionalCapabilities
2 parents ffb7a7a + 05015e7 commit 53396a5

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

pkg/clioptions/clusterdiscovery/provider.go

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -69,13 +69,17 @@ func InitializeTestFramework(context *e2e.TestContextType, config *ClusterConfig
6969
// IPFamily constants are taken from kube e2e and used by tests
7070
context.IPFamily = config.IPFamily
7171

72-
imageStreamString, _, err := exutil.NewCLIWithoutNamespace("").AsAdmin().Run("adm", "release", "info", `-ojsonpath={.references}`).Outputs()
73-
if err != nil {
74-
return err
75-
}
72+
// As an extra precaution for now, we do not run this check on all tests since some might fail to pull
73+
// release payload information
74+
if config.HasNoOptionalCapabilities {
75+
imageStreamString, _, err := exutil.NewCLIWithoutNamespace("").AsAdmin().Run("adm", "release", "info", `-ojsonpath={.references}`).Outputs()
76+
if err != nil {
77+
return err
78+
}
7679

77-
if err := image.InitializeReleasePullSpecString(imageStreamString, config.HasNoOptionalCapabilities); err != nil {
78-
return err
80+
if err := image.InitializeReleasePullSpecString(imageStreamString, config.HasNoOptionalCapabilities); err != nil {
81+
return err
82+
}
7983
}
8084

8185
return nil

0 commit comments

Comments
 (0)