Skip to content

Commit 553866f

Browse files
Merge pull request #29435 from jianzhangbjz/metrics
OCPBUGS-48340: skip OperatorHubSourceError metric checking when disableAllDefaultSources is true
2 parents 752741e + 0c45942 commit 553866f

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

test/extended/prometheus/prometheus.go

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -747,6 +747,10 @@ var _ = g.Describe("[sig-instrumentation] Prometheus [apigroup:image.openshift.i
747747
if isManagedService {
748748
allowedAlertNames = append(allowedAlertNames, "KubeDaemonSetMisScheduled")
749749
}
750+
// https://issues.redhat.com/browse/OCPBUGS-48340
751+
if SkipOperatorHubMetricsCheck(oc) {
752+
allowedAlertNames = append(allowedAlertNames, "OperatorHubSourceError")
753+
}
750754

751755
tests := map[string]bool{
752756
// openshift-e2e-loki alerts should never fail this test, we've seen this happen on daemon set rollout stuck when CI loki was down.
@@ -1014,3 +1018,11 @@ func hasTelemeterClient(client clientset.Interface) bool {
10141018
}
10151019
return true
10161020
}
1021+
1022+
func SkipOperatorHubMetricsCheck(oc *exutil.CLI) bool {
1023+
stdout, stderr, err := oc.AsAdmin().Run("get").Args("operatorhub", "cluster", "-o=jsonpath={.spec.disableAllDefaultSources}").Outputs()
1024+
if err != nil {
1025+
fmt.Printf("command failed: %v\nstderr: %s\nstdout:%s", err, stderr, stdout)
1026+
}
1027+
return stdout == "true"
1028+
}

0 commit comments

Comments
 (0)