Skip to content

Commit 70e7a31

Browse files
committed
Drop the ClusterOperatorDown/Degraded alert tests
These turn out to be a duplication of tests that already flake if an operator does Available=false or Degraded=true in a test run. (i.e. [bz-DNS] clusteroperator/dns should not change condition/Degraded)
1 parent 5103297 commit 70e7a31

File tree

1 file changed

+0
-9
lines changed
  • pkg/monitortestlibrary/allowedalerts

1 file changed

+0
-9
lines changed

pkg/monitortestlibrary/allowedalerts/all.go

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,6 @@ func AllAlertTests(jobType *platformidentification.JobType, etcdAllowance AlertT
1515
ret = append(ret, newNamespacedAlert("KubePodNotReady", jobType).pending().neverFail().toTests()...)
1616
ret = append(ret, newNamespacedAlert("KubePodNotReady", jobType).firing().toTests()...)
1717

18-
// ClusterOperatorDown and ClusterOperatorDegraded should not occur during a normal upgrade.
19-
// In CI firing is rare, but does happen a few times a month. Pending however occurs all the time, which implies operators are routinely in
20-
// a state they're not supposed to be during upgrade.
21-
// https://github.com/openshift/enhancements/blob/cb81452fddf86c1099acd87610b88369cd6192db/dev-guide/cluster-version-operator/dev/clusteroperator.md#there-are-a-set-of-guarantees-components-are-expected-to-honor-in-return
22-
ret = append(ret, newAlert("Cluster Version Operator", "ClusterOperatorDown", jobType).pending().alwaysFlake().toTests()...)
23-
ret = append(ret, newAlert("Cluster Version Operator", "ClusterOperatorDegraded", jobType).pending().alwaysFlake().toTests()...)
24-
ret = append(ret, newAlert("Cluster Version Operator", "ClusterOperatorDown", jobType).firing().alwaysFlake().toTests()...)
25-
ret = append(ret, newAlert("Cluster Version Operator", "ClusterOperatorDegraded", jobType).firing().alwaysFlake().toTests()...)
26-
2718
ret = append(ret, newAlert("etcd", "etcdMembersDown", jobType).pending().neverFail().toTests()...)
2819
ret = append(ret, newAlert("etcd", "etcdMembersDown", jobType).firing().toTests()...)
2920
ret = append(ret, newAlert("etcd", "etcdGRPCRequestsSlow", jobType).pending().neverFail().toTests()...)

0 commit comments

Comments
 (0)