Skip to content

Commit 7c50620

Browse files
committed
update based on comments
1 parent f993b85 commit 7c50620

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

test/extended/prometheus/prometheus.go

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -529,13 +529,10 @@ var _ = g.Describe("[sig-instrumentation][Late] Alerts", func() {
529529
// we only consider series sent since the beginning of the test
530530
testDuration := exutil.DurationSinceStartInSeconds().String()
531531

532-
var averageSeriesLimit int
533-
averageSeriesLimit = 1000
534-
535532
tests := map[string]bool{
536533
// We want to limit the number of total series sent, the cluster:telemetry_selected_series:count
537534
// rule contains the count of the all the series that are sent via telemetry. It is permissible
538-
// for some scenarios to generate more series than 1000, we just want the basic state to be below
535+
// for some scenarios to generate more series than the limit, we just want the basic state to be below
539536
// a threshold.
540537

541538
// The following query can be executed against the telemetry server
@@ -550,8 +547,8 @@ var _ = g.Describe("[sig-instrumentation][Late] Alerts", func() {
550547
// )[30m:1m]
551548
// )
552549
// )
553-
fmt.Sprintf(`avg_over_time(cluster:telemetry_selected_series:count[%s]) >= %d`, testDuration, averageSeriesLimit): false,
554-
fmt.Sprintf(`max_over_time(cluster:telemetry_selected_series:count[%s]) >= 1200`, testDuration): false,
550+
fmt.Sprintf(`avg_over_time(cluster:telemetry_selected_series:count[%s]) >= 1000`, testDuration): false,
551+
fmt.Sprintf(`max_over_time(cluster:telemetry_selected_series:count[%s]) >= 1200`, testDuration): false,
555552
}
556553
err := helper.RunQueries(context.TODO(), oc.NewPrometheusClient(context.TODO()), tests, oc)
557554
o.Expect(err).NotTo(o.HaveOccurred())

0 commit comments

Comments
 (0)