Skip to content

Commit 872603e

Browse files
committed
update machines scale test
this change adds an extra retry period for marking machines to scale down. this change is being added to help improve API interactions when there might be network disruptions within the cluster, or in cases where the record has been updated by another controller.
1 parent 5ef42f5 commit 872603e

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

test/extended/machines/scale.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -287,8 +287,9 @@ var _ = g.Describe("[sig-cluster-lifecycle][Feature:Machines][Serial] Managed cl
287287
for _, machineSet := range machineSets {
288288
newestMachine, err := getNewestMachineNameFromMachineSet(dc, machineName(machineSet))
289289
o.Expect(err).NotTo(o.HaveOccurred())
290-
err = markMachineForScaleDown(dc, newestMachine)
291-
o.Expect(err).NotTo(o.HaveOccurred())
290+
o.Eventually(func() error {
291+
return markMachineForScaleDown(dc, newestMachine)
292+
}, 3*time.Minute, 5*time.Second).Should(o.Succeed(), "Unable to mark Machine %q for scale down", newestMachine)
292293
}
293294

294295
g.By("scaling the machinesets back to their original size")

0 commit comments

Comments
 (0)