Skip to content

Commit 8852d04

Browse files
committed
trt-2246: isolate sig-network k8s tests
1 parent db175b3 commit 8852d04

File tree

1 file changed

+18
-7
lines changed

1 file changed

+18
-7
lines changed

pkg/test/ginkgo/cmd_runsuite.go

Lines changed: 18 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -437,6 +437,10 @@ func (o *GinkgoRunSuiteOptions) Run(suite *TestSuite, clusterConfig *clusterdisc
437437
return strings.Contains(t.name, "[sig-storage]")
438438
})
439439

440+
networkK8sTests, kubeTests := splitTests(kubeTests, func(t *testCase) bool {
441+
return strings.Contains(t.name, "[sig-network]")
442+
})
443+
440444
buildsTests, openshiftTests := splitTests(openshiftTests, func(t *testCase) bool {
441445
return strings.Contains(t.name, "[sig-builds]")
442446
})
@@ -452,8 +456,9 @@ func (o *GinkgoRunSuiteOptions) Run(suite *TestSuite, clusterConfig *clusterdisc
452456
logrus.Infof("Found %d openshift tests", len(openshiftTests))
453457
logrus.Infof("Found %d kube tests", len(kubeTests))
454458
logrus.Infof("Found %d storage tests", len(storageTests))
455-
logrus.Infof("Found %d builds tests", len(buildsTests))
459+
logrus.Infof("Found %d network k8s tests", len(networkK8sTests))
456460
logrus.Infof("Found %d network tests", len(networkTests))
461+
logrus.Infof("Found %d builds tests", len(buildsTests))
457462
logrus.Infof("Found %d must-gather tests", len(mustGatherTests))
458463

459464
// If user specifies a count, duplicate the kube and openshift tests that many times.
@@ -462,20 +467,22 @@ func (o *GinkgoRunSuiteOptions) Run(suite *TestSuite, clusterConfig *clusterdisc
462467
originalKube := kubeTests
463468
originalOpenshift := openshiftTests
464469
originalStorage := storageTests
465-
originalBuilds := buildsTests
470+
originalNetworkK8s := networkK8sTests
466471
originalNetwork := networkTests
472+
originalBuilds := buildsTests
467473
originalMustGather := mustGatherTests
468474

469475
for i := 1; i < count; i++ {
470476
kubeTests = append(kubeTests, copyTests(originalKube)...)
471477
openshiftTests = append(openshiftTests, copyTests(originalOpenshift)...)
472478
storageTests = append(storageTests, copyTests(originalStorage)...)
473-
buildsTests = append(buildsTests, copyTests(originalBuilds)...)
479+
networkK8sTests = append(networkK8sTests, copyTests(originalNetworkK8s)...)
474480
networkTests = append(networkTests, copyTests(originalNetwork)...)
481+
buildsTests = append(buildsTests, copyTests(originalBuilds)...)
475482
mustGatherTests = append(mustGatherTests, copyTests(originalMustGather)...)
476483
}
477484
}
478-
expectedTestCount += len(openshiftTests) + len(kubeTests) + len(storageTests) + len(buildsTests) + len(networkTests) + len(mustGatherTests)
485+
expectedTestCount += len(openshiftTests) + len(kubeTests) + len(storageTests) + len(networkK8sTests) + len(networkTests) + len(buildsTests) + len(mustGatherTests)
479486

480487
abortFn := neverAbort
481488
testCtx := ctx
@@ -505,14 +512,18 @@ func (o *GinkgoRunSuiteOptions) Run(suite *TestSuite, clusterConfig *clusterdisc
505512
q.Execute(testCtx, storageTestsCopy, max(1, parallelism/2), testOutputConfig, abortFn) // storage tests only run at half the parallelism, so we can avoid cloud provider quota problems.
506513
tests = append(tests, storageTestsCopy...)
507514

508-
buildsTestsCopy := copyTests(buildsTests)
509-
q.Execute(testCtx, buildsTestsCopy, max(1, parallelism/2), testOutputConfig, abortFn) // builds tests only run at half the parallelism, so we can avoid high cpu problems.
510-
tests = append(tests, buildsTestsCopy...)
515+
networkK8sTestsCopy := copyTests(networkK8sTests)
516+
q.Execute(testCtx, networkK8sTestsCopy, max(1, parallelism), testOutputConfig, abortFn) // run network tests separately.
517+
tests = append(tests, networkK8sTestsCopy...)
511518

512519
networkTestsCopy := copyTests(networkTests)
513520
q.Execute(testCtx, networkTestsCopy, max(1, parallelism), testOutputConfig, abortFn) // run network tests separately.
514521
tests = append(tests, networkTestsCopy...)
515522

523+
buildsTestsCopy := copyTests(buildsTests)
524+
q.Execute(testCtx, buildsTestsCopy, max(1, parallelism/2), testOutputConfig, abortFn) // builds tests only run at half the parallelism, so we can avoid high cpu problems.
525+
tests = append(tests, buildsTestsCopy...)
526+
516527
openshiftTestsCopy := copyTests(openshiftTests)
517528
q.Execute(testCtx, openshiftTestsCopy, parallelism, testOutputConfig, abortFn)
518529
tests = append(tests, openshiftTestsCopy...)

0 commit comments

Comments
 (0)