Skip to content

Commit 9c9ff1f

Browse files
committed
Stop disruption testing when platform is unknown
1 parent 24031fa commit 9c9ff1f

File tree

1 file changed

+20
-1
lines changed

1 file changed

+20
-1
lines changed

pkg/monitortestlibrary/disruptionlibrary/disruption_invariant_adapter.go

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,24 @@ func (w *Availability) CollectData(ctx context.Context) (monitorapi.Intervals, [
9999
return nil, nil, utilerrors.NewAggregate([]error{newRecoverErr, reusedRecoverErr})
100100
}
101101

102-
func createDisruptionJunit(testName string, allowedDisruption *time.Duration, disruptionDetails string, locator monitorapi.Locator, disruptedIntervals monitorapi.Intervals) *junitapi.JUnitTestCase {
102+
func createDisruptionJunit(
103+
testName string,
104+
allowedDisruption *time.Duration,
105+
disruptionDetails string,
106+
locator monitorapi.Locator,
107+
disruptedIntervals monitorapi.Intervals,
108+
jobType *platformidentification.JobType) *junitapi.JUnitTestCase {
109+
110+
// Not sure what these are, but this will help find them, and we don't get any value from testing these:
111+
if jobType.Platform == "" {
112+
return &junitapi.JUnitTestCase{
113+
Name: testName,
114+
SkipMessage: &junitapi.SkipMessage{
115+
Message: "Unknown platform, skipping disruption testing",
116+
},
117+
}
118+
}
119+
103120
// Indicates there is no entry in the query_results.json data file, nor a valid fallback,
104121
// we do not wish to run the test. (this likely implies we do not have the required number of
105122
// runs in 3 weeks to do a reliable P99)
@@ -177,6 +194,7 @@ func (w *Availability) junitForNewConnections(ctx context.Context, finalInterval
177194
monitorapi.IsErrorEvent,
178195
),
179196
),
197+
jobType,
180198
),
181199
nil
182200
}
@@ -194,6 +212,7 @@ func (w *Availability) junitForReusedConnections(ctx context.Context, finalInter
194212
monitorapi.IsErrorEvent,
195213
),
196214
),
215+
jobType,
197216
),
198217
nil
199218
}

0 commit comments

Comments
 (0)