pkg/monitortests/clusterversionoperator/legacycvomonitortests: Return happy-case pass JUnit

Avoid issues in aggregated jobs like [1]:

  : [bz-DNS] clusteroperator/dns should not change condition/Degraded expand_less	0s
  {Passed 4 times, failed 0 times, skipped 0 times: we require at least 6 attempts to have a chance at success  name: '[bz-DNS] clusteroperator/dns should not change condition/Degraded'

where of the 10 runs, 4 flaked, and the rest did not include JUnit for
this test-case at all.  With this pivot, the happy jobs will have
JUnit for the test-case asserting that the test suite is completely
happy with how this ClusterOperator handled Degraded.

Author: wking

pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go

@@ -167,10 +167,6 @@ func testOperatorStateTransitions(events monitorapi.Intervals, conditionTypes []
 				}
 			}
 
-			if len(fatal) == 0 && len(excepted) == 0 {
-				continue // nothing to complain about
-			}
-
 			output := fmt.Sprintf("%d unexpected clusteroperator state transitions during e2e test run", len(fatal))
 			if len(fatal) > 0 {
 				output = fmt.Sprintf("%s.  These did not match any known exceptions, so they cause this test-case to fail:\n\n%v\n", output, strings.Join(fatal, "\n"))
@@ -184,17 +180,19 @@ func testOperatorStateTransitions(events monitorapi.Intervals, conditionTypes []
 				output = fmt.Sprintf("%s, as desired.", output)
 			}
 
-			ret = append(ret, &junitapi.JUnitTestCase{
-				Name:      testName,
-				Duration:  duration,
-				SystemOut: output,
-				FailureOutput: &junitapi.FailureOutput{
-					Output: output,
-				},
-			})
+			if len(fatal) > 0 || len(excepted) > 0 {
+				ret = append(ret, &junitapi.JUnitTestCase{
+					Name:      testName,
+					Duration:  duration,
+					SystemOut: output,
+					FailureOutput: &junitapi.FailureOutput{
+						Output: output,
+					},
+				})
+			}
 
 			if len(fatal) == 0 {
-				// add a success so we flake and don't fail
+				// add a success so we flake (or pass) and don't fail
 				ret = append(ret, &junitapi.JUnitTestCase{Name: testName})
 			}
 		}