Merge pull request #29279 from vrutkovs/interesting-cert-rotation-events-chart

API-1802: chart template: show cert rotation events

Author: openshift-merge-bot[bot]

e2echart/non-spyglass-e2e-chart-template.html

@@ -254,6 +254,7 @@ <h5 class="modal-title">Resource</h5>
                         <option value="e2e_test_failed">e2e Test Failed</option>
                         <option value="e2e_test_flaked">e2e Test Flaked</option>
                         <option value="interesting_events">Interesting Events</option>
+                        <option value="certificate_rotation">Certificate Rotation</option>
                     </select>
 `
 
@@ -296,6 +297,7 @@ <h5 class="modal-title">Resource</h5>
         eventInterval.categories.e2e_test_flaked = isE2EFlaked(eventInterval);
         eventInterval.categories.e2e_test_passed = isE2EPassed(eventInterval);
         eventInterval.categories.endpoint_availability = isEndpointConnectivity(eventInterval);
+        eventInterval.categories.certificate_rotation = isCertificateRotation(eventInterval);
         eventInterval.categories.uncategorized = !_.some(eventInterval.categories); // will save time later during filtering and re-rendering since we don't render any uncategorized events
     });
 
@@ -438,6 +440,52 @@ <h5 class="modal-title">Resource</h5>
         return eventInterval.source === "Alert"
     }
 
+
+    function isCertificateRotation(eventInterval) {
+        if (eventInterval.source != 'KubeEvent') {
+            return false
+        }
+        if (eventInterval.message.reason === "CertificateUpdated") {
+            return true
+        };
+        if (eventInterval.message.reason === "CertificateRemoved") {
+            return true
+        };
+        if (eventInterval.message.reason === "CertificateUpdateFailed") {
+            return true
+        };
+        if (eventInterval.message.reason === "ConfigMapUpdated") {
+            return true
+        };
+        if (eventInterval.message.reason === "SignerUpdateRequired") {
+            return true
+        };
+        if (eventInterval.message.reason === "CABundleUpdateRequired") {
+            return true
+        };
+        if (eventInterval.message.reason === "TargetUpdateRequired") {
+            return true
+        };
+        if (eventInterval.message.reason === "CSRCreated") {
+            return true
+        };
+        if (eventInterval.message.reason === "CSRApproved") {
+            return true
+        };
+        if (eventInterval.message.reason === "CertificateRotationStarted") {
+            return true
+        };
+        if (eventInterval.message.reason === "ClientCertificateCreated") {
+            return true
+        };
+        if (eventInterval.message.reason === "NoValidCertificateFound") {
+            return true
+        };
+        
+                
+        return false;
+    }
+
     function interestingEvents(item) {
         if (item.message.annotations["pathological"] === "true") {
             if (item.message.annotations["interesting"] === "true") {
@@ -866,6 +914,9 @@ <h5 class="modal-title">Resource</h5>
         timelineGroups.push({group: "interesting-events", data: []});
         createTimelineData(interestingEvents, timelineGroups[timelineGroups.length - 1].data, filteredEvents, "interesting_events");
 
+        timelineGroups.push({group: "certificate-rotation", data: []})
+        createTimelineData("CertificateRotation", timelineGroups[timelineGroups.length - 1].data, filteredEvents, "certificate_rotation")
+
         var segmentFunc = function (segment) {
             // Copy label to clipboard
             navigator.clipboard.writeText(segment.labelVal);

pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go

@@ -706,7 +706,7 @@ var KubeAPIServerAvoids500s = &SimplePathologicalEventMatcher{
 
 var CertificateRotation = &SimplePathologicalEventMatcher{
 	name:               "CertificateRotation",
-	messageReasonRegex: regexp.MustCompile(`^(CABundleUpdateRequired|SignerUpdateRequired|TargetUpdateRequired|CertificateUpdated|CertificateRemoved|CertificateUpdateFailed)$`),
+	messageReasonRegex: regexp.MustCompile(`^(CABundleUpdateRequired|SignerUpdateRequired|TargetUpdateRequired|CertificateUpdated|CertificateRemoved|CertificateUpdateFailed|CSRCreated|CSRApproved|CertificateRotationStarted|ClientCertificateCreated|NoValidCertificateFound)$`),
 }
 
 // IsEventAfterInstallation returns true if the monitorEvent represents an event that happened after installation.

pkg/monitortests/testframework/watchevents/event.go

@@ -150,7 +150,7 @@ func recordAddOrUpdateEvent(
 				}
 			}
 		}
-	case "CABundleUpdateRequired", "SignerUpdateRequired", "TargetUpdateRequired", "CertificateUpdated", "CertificateRemoved", "CertificateUpdateFailed":
+	case "CABundleUpdateRequired", "SignerUpdateRequired", "TargetUpdateRequired", "CertificateUpdated", "CertificateRemoved", "CertificateUpdateFailed", "CSRCreated", "CSRApproved", "CertificateRotationStarted", "ClientCertificateCreated", "NoValidCertificateFound":
 		message = message.WithAnnotation(monitorapi.AnnotationInteresting, "true")
 	default:
 	}