Commit c42fde3
committed
Handle empty message in Progressing=True condition of CO status
The job [1] spotted a corner case where CO emitted the empty message
when it reports Progressing=True. The empty message is not idea but
seem legit since the field is optional [2]. The reason field could
also be empty but I do not see any CO popping up like it.
A unit test is added to cover this case. The input of the case is
taken from [3].
[1]. https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/30154/pull-ci-openshift-origin-main-e2e-aws-ovn-single-node-upgrade/1960354194137288704
[2]. https://github.com/openshift/api/blob/94481d71bb6f3ce6019717ea7900e6f88f42fa2c/config/v1/types_cluster_operator.go#L145
[2]. https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/30154/pull-ci-openshift-origin-main-e2e-aws-ovn-single-node-upgrade/1960354194137288704/artifacts/e2e-aws-ovn-single-node-upgrade/single-node-e2e-test/artifacts/junit/adm-upgrade-status/adm-upgrade-status-2025-08-26%2016:59:14.041315708%20+0000%20UTC%20m=+773.120136531__20250826-164647.txt1 parent ed0e293 commit c42fde3
File tree
2 files changed
+32
-1
lines changed- pkg/monitortests/cli/adm_upgrade/status
2 files changed
+32
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
Lines changed: 31 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
134 | 134 | | |
135 | 135 | | |
136 | 136 | | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
137 | 159 | | |
138 | 160 | | |
139 | 161 | | |
| |||
236 | 258 | | |
237 | 259 | | |
238 | 260 | | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
239 | 270 | | |
240 | 271 | | |
241 | 272 | | |
| |||
0 commit comments