Skip to content

Commit c79bb50

Browse files
committed
additional defaults for MicroShift
1 parent 38d4e28 commit c79bb50

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

pkg/clioptions/clusterdiscovery/provider.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,8 @@ func DecodeProvider(providerTypeOrJSON string, dryRun, discover bool, clusterSta
126126
// Currently, for the sake of testing, MicroShift can always be assumed to be using OVNKubernetes
127127
config.NetworkPlugin = "OVNKubernetes"
128128
config.SingleReplicaTopology = true
129+
// Currently, for the sake of testing, MicroShift can always be assumed to be using ipv4
130+
config.IPFamily = "ipv4"
129131
}
130132

131133
return config, nil

pkg/test/ginkgo/cmd_runsuite.go

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -787,11 +787,17 @@ func determineEnvironmentFlags(ctx context.Context, upgrade bool, dryRun bool) (
787787

788788
envFlagBuilder := &extensions.EnvironmentFlagsBuilder{}
789789
envFlagBuilder.
790-
AddPlatform(config.ProviderName).
791790
AddNetwork(config.NetworkPlugin).
792791
AddNetworkStack(config.IPFamily).
793792
AddExternalConnectivity(determineExternalConnectivity(config))
794793

794+
platform := config.ProviderName
795+
// MicroShift is defined as "skeleton" in the providerName, but the flag should be "none"
796+
if platform == "skeleton" {
797+
platform = "none"
798+
}
799+
envFlagBuilder.AddPlatform(platform)
800+
795801
if config.SingleReplicaTopology {
796802
// In cases like Microshift, we will not be able to determine the clusterState,
797803
// so topology will be unset unless we default it properly here

0 commit comments

Comments
 (0)