Return early in StartCollection for unsupported tests

hongkailiu · hongkailiu · commit de89f9e0e94a · 2025-08-07T14:05:16.000-04:00
diff --git a/pkg/monitortests/cli/adm_upgrade/status/monitortest.go b/pkg/monitortests/cli/adm_upgrade/status/monitortest.go
@@ -97,6 +97,9 @@ func snapshotOcAdmUpgradeStatus(ch chan *snapshot) {
 }
 
 func (w *monitor) StartCollection(ctx context.Context, adminRESTConfig *rest.Config, recorder monitorapi.RecorderWriter) error {
+	if w.notSupportedReason != nil {
+		return w.notSupportedReason
+	}
 	// TODO: The double goroutine spawn should probably be placed under some abstraction
 	go func(ctx context.Context) {
 		snapshots := make(chan *snapshot)

Original file line number	Diff line number	Diff line change
`@@ -97,6 +97,9 @@ func snapshotOcAdmUpgradeStatus(ch chan *snapshot) {`
`97`	`97`	`}`
`98`	`98`
`99`	`99`	`func (w monitor) StartCollection(ctx context.Context, adminRESTConfig rest.Config, recorder monitorapi.RecorderWriter) error {`
	`100`	`+ if w.notSupportedReason != nil {`
	`101`	`+ return w.notSupportedReason`
	`102`	`+ }`
`100`	`103`	`// TODO: The double goroutine spawn should probably be placed under some abstraction`
`101`	`104`	`go func(ctx context.Context) {`
`102`	`105`	`snapshots := make(chan *snapshot)`