Skip to content

Commit dfb1d4a

Browse files
committed
NO-JIRA: Check spec for k8s tests
1 parent a8da2a2 commit dfb1d4a

File tree

1 file changed

+19
-1
lines changed

1 file changed

+19
-1
lines changed

pkg/test/ginkgo/cmd_runsuite.go

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -265,6 +265,13 @@ func (o *GinkgoRunSuiteOptions) Run(suite *TestSuite, clusterConfig *clusterdisc
265265
return fmt.Errorf("no tests to run")
266266
}
267267

268+
k8sTestNames := map[string]bool{}
269+
for _, t := range specs {
270+
if strings.Contains(t.ExtensionTestSpec.Source, "hyperkube") {
271+
k8sTestNames[t.Name] = true
272+
}
273+
}
274+
268275
tests, err := extensionTestSpecsToOriginTestCases(specs)
269276
if err != nil {
270277
return errors.WithMessage(err, "could not convert test specs to origin test cases")
@@ -472,7 +479,12 @@ func (o *GinkgoRunSuiteOptions) Run(suite *TestSuite, clusterConfig *clusterdisc
472479
return strings.Contains(t.name, "[sig-cli] oc adm must-gather")
473480
})
474481

482+
k8sTests, openshiftTests := splitTests(openshiftTests, func(t *testCase) bool {
483+
return k8sTestNames[t.name]
484+
})
485+
475486
logrus.Infof("Found %d openshift tests", len(openshiftTests))
487+
logrus.Infof("Found %d kubernetes tests", len(k8sTests))
476488
logrus.Infof("Found %d storage tests", len(storageTests))
477489
logrus.Infof("Found %d cli tests", len(cliTests))
478490
logrus.Infof("Found %d apps tests", len(appsTests))
@@ -491,6 +503,7 @@ func (o *GinkgoRunSuiteOptions) Run(suite *TestSuite, clusterConfig *clusterdisc
491503
originalNode := nodeTests
492504
originalNetwork := networkTests
493505
originalBuilds := buildsTests
506+
originalK8sTests := k8sTests
494507
originalMustGather := mustGatherTests
495508

496509
for i := 1; i < count; i++ {
@@ -501,10 +514,11 @@ func (o *GinkgoRunSuiteOptions) Run(suite *TestSuite, clusterConfig *clusterdisc
501514
nodeTests = append(nodeTests, copyTests(originalNode)...)
502515
networkTests = append(networkTests, copyTests(originalNetwork)...)
503516
buildsTests = append(buildsTests, copyTests(originalBuilds)...)
517+
k8sTests = append(k8sTests, copyTests(originalK8sTests)...)
504518
mustGatherTests = append(mustGatherTests, copyTests(originalMustGather)...)
505519
}
506520
}
507-
expectedTestCount += len(openshiftTests) + len(storageTests) + len(cliTests) + len(appsTests) + len(nodeTests) + len(networkTests) + len(buildsTests) + len(mustGatherTests)
521+
expectedTestCount += len(openshiftTests) + len(storageTests) + len(cliTests) + len(appsTests) + len(nodeTests) + len(networkTests) + len(buildsTests) + len(k8sTests) + len(mustGatherTests)
508522

509523
abortFn := neverAbort
510524
testCtx := ctx
@@ -551,6 +565,10 @@ func (o *GinkgoRunSuiteOptions) Run(suite *TestSuite, clusterConfig *clusterdisc
551565
q.Execute(testCtx, buildsTestsCopy, max(1, parallelism/2), testOutputConfig, abortFn) // builds tests only run at half the parallelism, so we can avoid high cpu problems.
552566
tests = append(tests, buildsTestsCopy...)
553567

568+
k8sTestCopy := copyTests(k8sTests)
569+
q.Execute(testCtx, k8sTestCopy, parallelism, testOutputConfig, abortFn)
570+
tests = append(tests, k8sTestCopy...)
571+
554572
openshiftTestsCopy := copyTests(openshiftTests)
555573
q.Execute(testCtx, openshiftTestsCopy, parallelism, testOutputConfig, abortFn)
556574
tests = append(tests, openshiftTestsCopy...)

0 commit comments

Comments
 (0)