Skip to content

Commit f5be161

Browse files
committed
test/extended/cli/adm_upgrade/recommend: Enable precheck and accept
These will fail without more work, and I'll come back and do that work in follow-up commits in this branch. Landing this enablement first makes it easy to iterate in pre-merge testing while I figure out what needs to be done.
1 parent cc048c3 commit f5be161

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

test/extended/cli/adm_upgrade/recommend.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ var _ = g.Describe("[Serial][sig-cli] oc adm upgrade recommend", g.Ordered, func
5454
})
5555

5656
g.It("runs successfully, even without upstream OpenShift Update Service customization", func() {
57-
_, err := oc.Run("adm", "upgrade", "recommend").EnvVar("OC_ENABLE_CMD_UPGRADE_RECOMMEND", "true").Output()
57+
_, err := oc.Run("adm", "upgrade", "recommend").EnvVar("OC_ENABLE_CMD_UPGRADE_RECOMMEND", "true").EnvVar("OC_ENABLE_CMD_UPGRADE_RECOMMEND_PRECHECK", "true").EnvVar("OC_ENABLE_CMD_UPGRADE_RECOMMEND_ACCEPT", "true").Output()
5858
o.Expect(err).NotTo(o.HaveOccurred())
5959
})
6060

@@ -65,7 +65,7 @@ var _ = g.Describe("[Serial][sig-cli] oc adm upgrade recommend", g.Ordered, func
6565
}
6666
restoreChannel = true
6767

68-
out, err := oc.Run("adm", "upgrade", "recommend").EnvVar("OC_ENABLE_CMD_UPGRADE_RECOMMEND", "true").Output()
68+
out, err := oc.Run("adm", "upgrade", "recommend").EnvVar("OC_ENABLE_CMD_UPGRADE_RECOMMEND", "true").EnvVar("OC_ENABLE_CMD_UPGRADE_RECOMMEND_PRECHECK", "true").EnvVar("OC_ENABLE_CMD_UPGRADE_RECOMMEND_ACCEPT", "true").Output()
6969
o.Expect(err).NotTo(o.HaveOccurred())
7070
err = matchRegexp(out, `.*The update channel has not been configured.*`)
7171
o.Expect(err).NotTo(o.HaveOccurred())
@@ -99,7 +99,7 @@ var _ = g.Describe("[Serial][sig-cli] oc adm upgrade recommend", g.Ordered, func
9999
})
100100

101101
g.It("runs successfully", func() {
102-
out, err := oc.Run("adm", "upgrade", "recommend").EnvVar("OC_ENABLE_CMD_UPGRADE_RECOMMEND", "true").Output()
102+
out, err := oc.Run("adm", "upgrade", "recommend").EnvVar("OC_ENABLE_CMD_UPGRADE_RECOMMEND", "true").EnvVar("OC_ENABLE_CMD_UPGRADE_RECOMMEND_PRECHECK", "true").EnvVar("OC_ENABLE_CMD_UPGRADE_RECOMMEND_ACCEPT", "true").Output()
103103
o.Expect(err).NotTo(o.HaveOccurred())
104104
err = matchRegexp(out, `.*Upstream update service: http://.*
105105
Channel: test-channel [(]available channels: other-channel, test-channel[)]
@@ -179,7 +179,7 @@ No updates available. You may still upgrade to a specific release image.*`)
179179
})
180180

181181
g.It("runs successfully when listing all updates", func() {
182-
out, err := oc.Run("adm", "upgrade", "recommend").EnvVar("OC_ENABLE_CMD_UPGRADE_RECOMMEND", "true").Output()
182+
out, err := oc.Run("adm", "upgrade", "recommend").EnvVar("OC_ENABLE_CMD_UPGRADE_RECOMMEND", "true").EnvVar("OC_ENABLE_CMD_UPGRADE_RECOMMEND_PRECHECK", "true").EnvVar("OC_ENABLE_CMD_UPGRADE_RECOMMEND_ACCEPT", "true").Output()
183183
o.Expect(err).NotTo(o.HaveOccurred())
184184
err = matchRegexp(out, `Upstream update service: http://.*
185185
Channel: test-channel [(]available channels: other-channel, test-channel[)]
@@ -199,7 +199,7 @@ Updates to 4[.][0-9]*:
199199
})
200200

201201
g.It("runs successfully with conditional recommendations to the --version target", func() {
202-
out, err := oc.Run("adm", "upgrade", "recommend", "--version", fmt.Sprintf("4.%d.0", currentVersion.Minor+1)).EnvVar("OC_ENABLE_CMD_UPGRADE_RECOMMEND", "true").Output()
202+
out, err := oc.Run("adm", "upgrade", "recommend", "--version", fmt.Sprintf("4.%d.0", currentVersion.Minor+1)).EnvVar("OC_ENABLE_CMD_UPGRADE_RECOMMEND", "true").EnvVar("OC_ENABLE_CMD_UPGRADE_RECOMMEND_PRECHECK", "true").EnvVar("OC_ENABLE_CMD_UPGRADE_RECOMMEND_ACCEPT", "true").Output()
203203
o.Expect(err).NotTo(o.HaveOccurred())
204204
err = matchRegexp(out, `Upstream update service: http://.*
205205
Channel: test-channel [(]available channels: other-channel, test-channel[)]

0 commit comments

Comments
 (0)