-
Notifications
You must be signed in to change notification settings - Fork 4.8k
CNTRLPLANE-1544: tests: authorization/rbac: Add restricted-v3 scc #30384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@tchap: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-job-with-prs pull-ci-openshift-cluster-kube-apiserver-operator-main-e2e-aws openshift/cluster-kube-apiserver-operator#1935 |
|
/payload-job-with-prs pull-ci-openshift-cluster-kube-apiserver-operator-main-e2e-aws openshift/cluster-kube-apiserver-operator#1935 |
|
@tchap: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
|
/payload-job-with-prs ci/prow/e2e-aws-ovn openshift/cluster-kube-apiserver-operator#1935 |
|
/payload-job-with-prs pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi openshift/cluster-kube-apiserver-operator#1935 |
|
@tchap: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
|
/payload-with-prs openshift/cluster-kube-apiserver-operator#1935 |
|
/payload-with-prs openshift/cluster-kube-apiserver-operator#1935 |
|
/payload-with-prs 4.21 ci openshift/cluster-kube-apiserver-operator#1935 |
|
/payload-with-prs 4.21 ci all openshift/cluster-kube-apiserver-operator#1935 |
|
@tchap: An error was encountered. No known errors were detected, please see the full error message for details. Full error message.
could not resolve jobs for 4.21 ci all: failed to request latest release: server responded with 400: error: jobType must be one of '', 'informing', 'blocking', 'disabled' or 'periodic'
Please contact an administrator to resolve this issue. |
|
/payload-with-prs 4.21 ci all informing openshift/cluster-kube-apiserver-operator#1935 |
|
@tchap: An error was encountered. No known errors were detected, please see the full error message for details. Full error message.
could not resolve jobs for 4.21 ci all: failed to request latest release: server responded with 400: error: jobType must be one of '', 'informing', 'blocking', 'disabled' or 'periodic'
Please contact an administrator to resolve this issue. |
|
/payload-with-prs 4.21 ci informing openshift/cluster-kube-apiserver-operator#1935 |
|
@tchap: trigger 1 job(s) of type informing for the ci release of OCP 4.21
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d6b1e380-aa85-11f0-95a7-712e44658b77-0 |
|
/retest |
|
@tchap: This PR was included in a payload test run from openshift/cluster-kube-apiserver-operator#1935
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/33e53000-aaa1-11f0-86f9-7907cfa77396-0 |
09aba2a to
e744d03
Compare
|
/retest |
e744d03 to
1435371
Compare
|
@tchap: This pull request references CNTRLPLANE-1544 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
We need to include restricted-v3 scc in the list of rules for authenticated users, but iff the associated ClusterRoleBinding exists. This is a temporary and conditional fix to make tests passing for openshift/cluster-kube-apiserver-operator#1944 A subsequent PR is gonna be opened once the PR above is merged.
1435371 to
b39fa71
Compare
|
@tchap: This PR was included in a payload test run from openshift/cluster-kube-apiserver-operator#1944
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b2df3500-af37-11f0-812a-d5b1ae1849ed-0 |
|
/retest-required |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liouk, tchap The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by "[sig-auth][Feature:OpenShiftAuthorization] The default cluster RBAC policy should have correct RBAC rules" |
|
@tchap: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: b39fa71
New tests seen in this PR at sha: b39fa71
|
1 similar comment
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: b39fa71
New tests seen in this PR at sha: b39fa71
|
|
@tchap: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: b39fa71
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: b39fa71
New tests seen in this PR at sha: b39fa71
|
|
Job Failure Risk Analysis for sha: b39fa71
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: b39fa71
New tests seen in this PR at sha: b39fa71
|
367ab40
into
openshift:main
|
/cherry-pick release-4.20 |
|
@haircommander: new pull request created: #30502 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
We need to include restricted-v3 scc in the list of rules for
authenticated users, but iff the associated ClusterRoleBinding exists.
This is a temporary and conditional fix to make tests passing for
openshift/cluster-kube-apiserver-operator#1944
A subsequent PR is gonna be opened once the PR above is merged.