Fix excludeSubnets bug found by rabbitai

kyrtapz · kyrtapz · commit 10338ca7de84 · 2025-08-20T13:39:16.000+02:00
Signed-off-by: Patryk Diak &lt;pdiak@redhat.com&gt;
diff --git a/go-controller/pkg/allocator/ip/subnet/allocator.go b/go-controller/pkg/allocator/ip/subnet/allocator.go
@@ -126,8 +126,8 @@ func (allocator *allocator) AddOrUpdateSubnet(config SubnetConfig) error {
 				if err != nil {
 					return fmt.Errorf("failed to exclude subnet %s for %s: %w", excludeFromIPAM, config.Name, err)
 				}
+				excluded = true
 			}
-			excluded = true
 		}
 		if !excluded {
 			return fmt.Errorf("failed to exclude subnet %s for %s: not contained in any of the subnets", excludeFromIPAM, config.Name)

Original file line number	Diff line number	Diff line change
`@@ -126,8 +126,8 @@ func (allocator *allocator) AddOrUpdateSubnet(config SubnetConfig) error {`
`126`	`126`	`if err != nil {`
`127`	`127`	`return fmt.Errorf("failed to exclude subnet %s for %s: %w", excludeFromIPAM, config.Name, err)`
`128`	`128`	`}`
	`129`	`+ excluded = true`
`129`	`130`	`}`
`130`		`- excluded = true`
`131`	`131`	`}`
`132`	`132`	`if !excluded {`
`133`	`133`	`return fmt.Errorf("failed to exclude subnet %s for %s: not contained in any of the subnets", excludeFromIPAM, config.Name)`