crds,udn: Allow NetworkRole Secondary only for Localnet topology

Localnet topology role should secondary only.
Move the NetworkRole enum validation from shard.go to
each definition that use NetworkRole, having:
- Layer2Config & Layer3Config role field accepts: Secondary and Primary.
- LocalnetConfig role field accepts: Secondary only.

Signed-off-by: Or Mergi <[email protected]>

Author: ormergi

dist/templates/k8s.ovn.org_clusteruserdefinednetworks.yaml.j2

@@ -420,7 +420,6 @@ spec:
                           The network will be assigned to pods that have the `k8s.v1.cni.cncf.io/networks` annotation in place pointing
                           to subject.
                         enum:
-                        - Primary
                         - Secondary
                         type: string
                       subnets:

go-controller/pkg/crd/userdefinednetwork/v1/cudn.go

@@ -98,6 +98,7 @@ type LocalnetConfig struct {
 	// The network will be assigned to pods that have the `k8s.v1.cni.cncf.io/networks` annotation in place pointing
 	// to subject.
 	//
+	// +kubebuilder:validation:Enum=Secondary
 	// +required
 	Role NetworkRole `json:"role"`
 

go-controller/pkg/crd/userdefinednetwork/v1/shared.go

@@ -32,6 +32,7 @@ type Layer3Config struct {
 	// Primary network is automatically assigned to every pod created in the same namespace.
 	// Secondary network is only assigned to pods that use `k8s.v1.cni.cncf.io/networks` annotation to select given network.
 	//
+	// +kubebuilder:validation:Enum=Primary;Secondary
 	// +kubebuilder:validation:Required
 	// +required
 	Role NetworkRole `json:"role"`
@@ -96,6 +97,7 @@ type Layer2Config struct {
 	// Allowed value is "Secondary".
 	// Secondary network is only assigned to pods that use `k8s.v1.cni.cncf.io/networks` annotation to select given network.
 	//
+	// +kubebuilder:validation:Enum=Primary;Secondary
 	// +kubebuilder:validation:Required
 	// +required
 	Role NetworkRole `json:"role"`
@@ -165,7 +167,6 @@ const (
 	IPAMDisabled IPAMMode = "Disabled"
 )
 
-// +kubebuilder:validation:Enum=Primary;Secondary
 type NetworkRole string
 
 const (