[lint] add make lint-fix command to fix lint issues

Add exit 1 to fail make command when container_runtime is
not present.

Signed-off-by: Nadia Pinaeva <[email protected]>

Author: npinaeva

go-controller/Makefile

@@ -93,9 +93,17 @@ clean:
 
 lint:
 ifeq ($(CONTAINER_RUNNABLE), 0)
-	@GOPATH=${GOPATH} ./hack/lint.sh $(CONTAINER_RUNTIME)
+	@GOPATH=${GOPATH} ./hack/lint.sh $(CONTAINER_RUNTIME) || { echo "lint failed! Try running 'make lint-fix'"; exit 1; }
 else
-	echo "linter can only be run within a container since it needs a specific golangci-lint version"
+	echo "linter can only be run within a container since it needs a specific golangci-lint version"; exit 1
+endif
+
+lint-fix:
+ifeq ($(CONTAINER_RUNNABLE), 0)
+	@GOPATH=${GOPATH} ./hack/lint.sh $(CONTAINER_RUNTIME) fix || { echo "ERROR: lint fix failed! There is a bug that changes file ownership to root \
+	when this happens. To fix it, simply run 'chown -R <user>:<group> *' from the repo root."; exit 1; }
+else
+	echo "linter can only be run within a container since it needs a specific golangci-lint version"; exit 1
 endif
 
 gofmt:

go-controller/hack/lint.sh

@@ -1,14 +1,18 @@
 #!/usr/bin/env bash
-
 VERSION=v1.60.3
+extra_flags=""
 if [ "$#" -ne 1 ]; then
+  if [ "$#" -eq 2 ] && [ "$2" == "fix" ]; then
+    extra_flags="--fix"
+  else
     echo "Expected command line argument - container runtime (docker/podman) got $# arguments: $@"
     exit 1
+  fi
 fi
 
 $1 run --security-opt label=disable --rm \
   -v  ${HOME}/.cache/golangci-lint:/cache -e GOLANGCI_LINT_CACHE=/cache \
   -v $(pwd):/app -w /app -e GO111MODULE=on docker.io/golangci/golangci-lint:${VERSION} \
 	golangci-lint run --verbose --print-resources-usage \
-	--modules-download-mode=vendor --timeout=15m0s && \
-	echo "lint OK!"
+	--modules-download-mode=vendor --timeout=15m0s ${extra_flags} && \
+	echo "lint OK!"