e2e: Enable testing BGP using podman

When using podman, BGP test suite fails due to checks against
the env container runtime which are not compatible with podman:
- Inspecting network objects is not compatible due to diffrences in
  how podman and docker persist network objects
- List containers using JSON format

To overcome the above, change network inspect operation and container
list using format to a form that compatible with bot docker and podman.

Signed-off-by: Or Mergi <[email protected]>

Author: ormergi

test/e2e/containerengine/container_engine.go

@@ -12,6 +12,16 @@ func (ce ContainerEngine) String() string {
 	return string(ce)
 }
 
+func (ce ContainerEngine) NetworkCIDRsFmt() string {
+	if ce == Podman {
+		return "{{json .Subnets }}"
+	}
+	if ce == Docker {
+		return "{{json .IPAM.Config }}"
+	}
+	return ""
+}
+
 const (
 	Docker ContainerEngine = "docker"
 	Podman ContainerEngine = "podman"

test/e2e/infraprovider/providers/kind/kind.go

@@ -414,7 +414,6 @@ func (c *contextKind) cleanUp() error {
 
 const (
 	nameFormat                     = "{{.Name}}"
-	inspectNetworkIPAMJSON         = "{{json .IPAM.Config }}"
 	inspectNetworkIPv4GWKeyStr     = "{{ .NetworkSettings.Networks.%s.Gateway }}"
 	inspectNetworkIPv4AddrKeyStr   = "{{ .NetworkSettings.Networks.%s.IPAddress }}"
 	inspectNetworkIPv4PrefixKeyStr = "{{ .NetworkSettings.Networks.%s.IPPrefixLen }}"
@@ -437,7 +436,7 @@ func isNetworkAttachedToContainer(networkName, containerName string) bool {
 
 func doesContainerNameExist(name string) bool {
 	// check if it is present before retrieving logs
-	stdOut, err := exec.Command(containerengine.Get().String(), "ps", "-f", fmt.Sprintf("Name=^%s$", name), "-q").CombinedOutput()
+	stdOut, err := exec.Command(containerengine.Get().String(), "ps", "-f", fmt.Sprintf("name=^%s$", name), "-q").CombinedOutput()
 	if err != nil {
 		panic(fmt.Sprintf("failed to check if external container (%s) exists: %v (%s)", name, err, stdOut))
 	}
@@ -466,13 +465,16 @@ func getNetwork(networkName string) (containerEngineNetwork, error) {
 		return n, api.NotFound
 	}
 	configs := make([]containerEngineNetworkConfig, 0, 1)
-	dataBytes, err := exec.Command(containerengine.Get().String(), "network", "inspect", "-f", inspectNetworkIPAMJSON, networkName).CombinedOutput()
+
+	ce := containerengine.Get()
+	netConfFmt := ce.NetworkCIDRsFmt()
+	dataBytes, err := exec.Command(ce.String(), "network", "inspect", "-f", netConfFmt, networkName).CombinedOutput()
 	if err != nil {
 		return n, fmt.Errorf("failed to extract network %q data: %v", networkName, err)
 	}
 	dataBytes = []byte(strings.Trim(string(dataBytes), "\n"))
 	if err = json.Unmarshal(dataBytes, &configs); err != nil {
-		return n, fmt.Errorf("failed to unmarshall network %q configuration using network inspect -f %q: %v", networkName, inspectNetworkIPAMJSON, err)
+		return n, fmt.Errorf("failed to unmarshall network %q configuration using network inspect -f %q: %v", networkName, netConfFmt, err)
 	}
 	if len(configs) == 0 {
 		return n, fmt.Errorf("failed to find any IPAM configuration for network %s", networkName)