Skip to content

Commit 59656d8

Browse files
committed
Adapt e2e tests to new universal network selector API
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>
1 parent 2af5f56 commit 59656d8

File tree

3 files changed

+34
-24
lines changed

3 files changed

+34
-24
lines changed

test/e2e/go.mod

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ require (
165165
gopkg.in/warnings.v0 v0.1.2 // indirect
166166
gopkg.in/yaml.v3 v3.0.1 // indirect
167167
gotest.tools/v3 v3.5.0 // indirect
168-
k8s.io/apiextensions-apiserver v0.32.1 // indirect
168+
k8s.io/apiextensions-apiserver v0.32.3 // indirect
169169
k8s.io/apiserver v0.32.3 // indirect
170170
k8s.io/cloud-provider v0.32.3 // indirect
171171
k8s.io/component-base v0.32.3 // indirect
@@ -197,7 +197,7 @@ require (
197197
github.com/google/goexpect v0.0.0-20210430020637-ab937bf7fd6f
198198
github.com/onsi/ginkgo v1.16.5
199199
github.com/openshift-kni/k8sreporter v1.0.6
200-
github.com/ovn-org/ovn-kubernetes/go-controller v0.0.0-20250304211626-ab2bbed40acc
200+
github.com/ovn-org/ovn-kubernetes/go-controller v1.0.0
201201
go.universe.tf/metallb v0.0.0-00010101000000-000000000000
202202
google.golang.org/grpc v1.65.0
203203
gopkg.in/yaml.v2 v2.4.0
@@ -206,6 +206,8 @@ require (
206206
sigs.k8s.io/controller-runtime v0.20.3
207207
)
208208

209-
replace go.universe.tf/metallb => github.com/metallb/metallb v0.14.9
210-
211-
replace github.com/coreos/go-iptables => github.com/trozet/go-iptables v0.0.0-20240328221912-077e672b3808
209+
replace (
210+
github.com/coreos/go-iptables => github.com/trozet/go-iptables v0.0.0-20240328221912-077e672b3808
211+
github.com/ovn-org/ovn-kubernetes/go-controller => ../../go-controller
212+
go.universe.tf/metallb => github.com/metallb/metallb v0.14.9
213+
)

test/e2e/go.sum

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -441,8 +441,6 @@ github.com/openshift/client-go v0.0.0-20231121143148-910ca30a1a9a h1:4FVrw8hz0Wb
441441
github.com/openshift/client-go v0.0.0-20231121143148-910ca30a1a9a/go.mod h1:arApQobmOjZqtxw44TwnQdUCH+t9DgZ8geYPFqksHws=
442442
github.com/openshift/custom-resource-status v1.1.2 h1:C3DL44LEbvlbItfd8mT5jWrqPfHnSOQoQf/sypqA6A4=
443443
github.com/openshift/custom-resource-status v1.1.2/go.mod h1:DB/Mf2oTeiAmVVX1gN+NEqweonAPY0TKUwADizj8+ZA=
444-
github.com/ovn-org/ovn-kubernetes/go-controller v0.0.0-20250304211626-ab2bbed40acc h1:CcaFTAAnkXtWwsIYl7D2Yq0YQ8u7jk7nOyKlrKOfxmA=
445-
github.com/ovn-org/ovn-kubernetes/go-controller v0.0.0-20250304211626-ab2bbed40acc/go.mod h1:MzFM3OEsLM2w/4MBMOCsxGR6ZBUvJfOxvQHB8LIKSv4=
446444
github.com/peterbourgon/diskv v2.0.1+incompatible/go.mod h1:uqqh8zWWbv1HBMNONnaR/tNboyR3/BZd58JJSHlUSCU=
447445
github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4=
448446
github.com/pkg/errors v0.9.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
@@ -990,8 +988,8 @@ k8s.io/api v0.22.7/go.mod h1:7hejA1BgBEiSsWljUyRkIjj+AISXO16IwsaDgFjJsQE=
990988
k8s.io/api v0.23.3/go.mod h1:w258XdGyvCmnBj/vGzQMj6kzdufJZVUwEM1U2fRJwSQ=
991989
k8s.io/api v0.32.3 h1:Hw7KqxRusq+6QSplE3NYG4MBxZw1BZnq4aP4cJVINls=
992990
k8s.io/api v0.32.3/go.mod h1:2wEDTXADtm/HA7CCMD8D8bK4yuBUptzaRhYcYEEYA3k=
993-
k8s.io/apiextensions-apiserver v0.32.1 h1:hjkALhRUeCariC8DiVmb5jj0VjIc1N0DREP32+6UXZw=
994-
k8s.io/apiextensions-apiserver v0.32.1/go.mod h1:sxWIGuGiYov7Io1fAS2X06NjMIk5CbRHc2StSmbaQto=
991+
k8s.io/apiextensions-apiserver v0.32.3 h1:4D8vy+9GWerlErCwVIbcQjsWunF9SUGNu7O7hiQTyPY=
992+
k8s.io/apiextensions-apiserver v0.32.3/go.mod h1:8YwcvVRMVzw0r1Stc7XfGAzB/SIVLunqApySV5V7Dss=
995993
k8s.io/apimachinery v0.22.7/go.mod h1:ZvVLP5iLhwVFg2Yx9Gh5W0um0DUauExbRhe+2Z8I1EU=
996994
k8s.io/apimachinery v0.23.3/go.mod h1:BEuFMMBaIbcOqVIJqNZJXGFTP4W6AycEpb5+m/97hrM=
997995
k8s.io/apimachinery v0.32.3 h1:JmDuDarhDmA/Li7j3aPrwhpNBA94Nvk5zLeOge9HH1U=

test/e2e/route_advertisements.go

Lines changed: 25 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,10 @@ import (
1212
"github.com/onsi/ginkgo/v2"
1313
"github.com/onsi/gomega"
1414
rav1 "github.com/ovn-org/ovn-kubernetes/go-controller/pkg/crd/routeadvertisements/v1"
15-
applycfgrav1 "github.com/ovn-org/ovn-kubernetes/go-controller/pkg/crd/routeadvertisements/v1/apis/applyconfiguration/routeadvertisements/v1"
1615
raclientset "github.com/ovn-org/ovn-kubernetes/go-controller/pkg/crd/routeadvertisements/v1/apis/clientset/versioned"
16+
apitypes "github.com/ovn-org/ovn-kubernetes/go-controller/pkg/crd/types"
1717
udnv1 "github.com/ovn-org/ovn-kubernetes/go-controller/pkg/crd/userdefinednetwork/v1"
1818
udnclientset "github.com/ovn-org/ovn-kubernetes/go-controller/pkg/crd/userdefinednetwork/v1/apis/clientset/versioned"
19-
v1 "k8s.io/client-go/applyconfigurations/meta/v1"
2019

2120
corev1 "k8s.io/api/core/v1"
2221
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -588,22 +587,33 @@ var _ = ginkgo.DescribeTableSubtree("BGP: isolation between advertised networks"
588587
gomega.Expect(err).NotTo(gomega.HaveOccurred())
589588

590589
ginkgo.By("Expose networks")
591-
raCfg := applycfgrav1.RouteAdvertisements("advertised-networks-isolation-ra").
592-
WithSpec(
593-
applycfgrav1.RouteAdvertisementsSpec().
594-
WithAdvertisements(rav1.PodNetwork).
595-
WithNetworkSelector(
596-
v1.LabelSelector().WithMatchLabels(map[string]string{"advertised-networks-isolation":""}),
597-
),
598-
)
590+
ra := &rav1.RouteAdvertisements{
591+
ObjectMeta: metav1.ObjectMeta{
592+
GenerateName: "advertised-networks-isolation-ra",
593+
},
594+
Spec: rav1.RouteAdvertisementsSpec{
595+
NetworkSelectors: apitypes.NetworkSelectors{
596+
apitypes.NetworkSelector{
597+
NetworkSelectionType: apitypes.ClusterUserDefinedNetworks,
598+
ClusterUserDefinedNetworkSelector: &apitypes.ClusterUserDefinedNetworkSelector{
599+
NetworkSelector: metav1.LabelSelector{
600+
MatchLabels: map[string]string{"advertised-networks-isolation": ""},
601+
},
602+
},
603+
},
604+
},
605+
NodeSelector: metav1.LabelSelector{},
606+
FRRConfigurationSelector: metav1.LabelSelector{},
607+
Advertisements: []rav1.AdvertisementType{
608+
rav1.PodNetwork,
609+
},
610+
},
611+
}
599612

600613
raClient, err := raclientset.NewForConfig(f.ClientConfig())
601614
gomega.Expect(err).NotTo(gomega.HaveOccurred())
602615

603-
ra, err = raClient.K8sV1().RouteAdvertisements().Apply(context.TODO(), raCfg, metav1.ApplyOptions{
604-
FieldManager: f.Namespace.Name,
605-
Force: true,
606-
})
616+
ra, err = raClient.K8sV1().RouteAdvertisements().Create(context.TODO(), ra, metav1.CreateOptions{})
607617
gomega.Expect(err).NotTo(gomega.HaveOccurred())
608618

609619
ginkgo.By("ensure route advertisement matching both networks was created successfully")
@@ -670,7 +680,7 @@ var _ = ginkgo.DescribeTableSubtree("BGP: isolation between advertised networks"
670680
// checkConnectivity performs a curl command from a specified client (pod or node)
671681
// to targetAddress. If clientNamespace is empty the function assumes clientName is a node that will be used as the
672682
// client.
673-
var checkConnectivity = func (clientName, clientNamespace, targetAddress string) (string, error) {
683+
var checkConnectivity = func(clientName, clientNamespace, targetAddress string) (string, error) {
674684
curlCmd := []string{"curl", "-g", "-q", "-s", "--max-time", "5", targetAddress}
675685
var out string
676686
var err error

0 commit comments

Comments
 (0)