Remove NetworkUnavailable condition from node

The NodeNetworkUnavailable condition can be set after ovn-k processed
the node successfully so we cannot do the early exit without checking
for this.

Order of events:

1. Node is added without the NodeNetworkUnavailable condition
2. OVN-Kubernetes reconciles the node
3. Condition is added by an external entity
4. We never remove it because we exit early

Hence this commit adds NodeNetworkUnavailable condition check for node
update event and ensures h.clearInitialNodeNetworkUnavailableCondition
method is called at least once to clear this condition.

Signed-off-by: Periyasamy Palanisamy <[email protected]>

Author: pperiyasamy

go-controller/pkg/clustermanager/network_cluster_controller.go

@@ -16,6 +16,7 @@ import (
 	cache "k8s.io/client-go/tools/cache"
 	"k8s.io/client-go/tools/record"
 	"k8s.io/client-go/util/retry"
+	k8snodeutil "k8s.io/component-helpers/node/util"
 	"k8s.io/klog/v2"
 
 	"github.com/ovn-org/ovn-kubernetes/go-controller/pkg/allocator/id"
@@ -576,7 +577,10 @@ func (h *networkClusterControllerEventHandler) UpdateResource(oldObj, newObj int
 		// 1. we missed an add event (bug in kapi informer code)
 		// 2. a user removed the annotation on the node
 		// Either way to play it safe for now do a partial json unmarshal check
-		if !nodeFailed && util.NoHostSubnet(oldNode) == util.NoHostSubnet(newNode) && !h.ncc.nodeAllocator.NeedsNodeAllocation(newNode) {
+		_, nodeCondition := k8snodeutil.GetNodeCondition(&newNode.Status, corev1.NodeNetworkUnavailable)
+		nodeNetworkUnavailable := nodeCondition != nil && nodeCondition.Status == corev1.ConditionTrue
+		if !nodeFailed && util.NoHostSubnet(oldNode) == util.NoHostSubnet(newNode) &&
+			!h.ncc.nodeAllocator.NeedsNodeAllocation(newNode) && !nodeNetworkUnavailable {
 			// no other node updates would require us to reconcile again
 			return nil
 		}