Skip to content

Commit f7db1c2

Browse files
kind: move KIND_IMAGE and K8S_VERSION to set_common_default_params
Signed-off-by: Flavio Fernandes <[email protected]>
1 parent c386b35 commit f7db1c2

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

contrib/kind-common

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,11 @@ if_error_exit() {
3232
fi
3333
}
3434

35+
set_common_default_params() {
36+
KIND_IMAGE=${KIND_IMAGE:-kindest/node}
37+
K8S_VERSION=${K8S_VERSION:-v1.32.3}
38+
}
39+
3540
run_kubectl() {
3641
local retries=0
3742
local attempts=10

contrib/kind-helm.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ export OCI_BIN=${KIND_EXPERIMENTAL_PROVIDER:-docker}
1111
source "${DIR}/kind-common"
1212

1313
set_default_params() {
14+
set_common_default_params
1415

1516
# Set default values
1617
export KIND_CONFIG=${KIND_CONFIG:-}
@@ -326,7 +327,7 @@ networking:
326327
EOT
327328

328329
kind delete clusters $KIND_CLUSTER_NAME ||:
329-
kind create cluster --name $KIND_CLUSTER_NAME --config "${KIND_CONFIG}" --retain
330+
kind create cluster --name $KIND_CLUSTER_NAME --image "${KIND_IMAGE}":"${K8S_VERSION}" --config "${KIND_CONFIG}" --retain
330331
kind load docker-image --name $KIND_CLUSTER_NAME $OVN_IMAGE
331332

332333
# When using HA, label nodes to host db.

contrib/kind.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -512,6 +512,8 @@ set_openssl_binary() {
512512
}
513513

514514
set_default_params() {
515+
set_common_default_params
516+
515517
# Set default values
516518
# Used for multi cluster setups
517519
KIND_CREATE=${KIND_CREATE:-true}
@@ -528,8 +530,6 @@ set_default_params() {
528530
MANIFEST_OUTPUT_DIR="${DIR}/../dist/yaml/${KIND_CLUSTER_NAME}"
529531
fi
530532
RUN_IN_CONTAINER=${RUN_IN_CONTAINER:-false}
531-
KIND_IMAGE=${KIND_IMAGE:-kindest/node}
532-
K8S_VERSION=${K8S_VERSION:-v1.32.3}
533533
OVN_GATEWAY_MODE=${OVN_GATEWAY_MODE:-shared}
534534
KIND_INSTALL_INGRESS=${KIND_INSTALL_INGRESS:-false}
535535
KIND_INSTALL_METALLB=${KIND_INSTALL_METALLB:-false}

0 commit comments

Comments
 (0)