Skip to content

Commit f9e5482

Browse files
authored
Merge pull request #5304 from kyrtapz/node_tracker_optimization
NodeTracker: Only update the node if the subnet changed for the specific network
2 parents e5ce179 + 424a653 commit f9e5482

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

go-controller/pkg/ovn/controller/services/node_tracker.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ func (nt *nodeTracker) Start(nodeInformer coreinformers.NodeInformer) (cache.Res
119119
// - node changes its zone
120120
// - node becomes a hybrid overlay node from a ovn node or vice verse
121121
// . No need to trigger update for any other field change.
122-
if util.NodeSubnetAnnotationChanged(oldObj, newObj) ||
122+
if util.NodeSubnetAnnotationChangedForNetwork(oldObj, newObj, nt.netInfo.GetNetworkName()) ||
123123
util.NodeL3GatewayAnnotationChanged(oldObj, newObj) ||
124124
oldObj.Name != newObj.Name ||
125125
util.NodeHostCIDRsAnnotationChanged(oldObj, newObj) ||
@@ -169,7 +169,7 @@ func (nt *nodeTracker) updateNodeInfo(nodeName, switchName, routerName, chassisI
169169
ni.podSubnets = append(ni.podSubnets, *podSubnets[i]) // de-pointer
170170
}
171171

172-
klog.Infof("Node %s switch + router changed, syncing services", nodeName)
172+
klog.Infof("Node %s switch + router changed, syncing services in network %q", nodeName, nt.netInfo.GetNetworkName())
173173

174174
nt.Lock()
175175
defer nt.Unlock()
@@ -208,7 +208,7 @@ func (nt *nodeTracker) removeNode(nodeName string) {
208208
// The switch exists when the HostSubnet annotation is set.
209209
// The gateway router will exist sometime after the L3Gateway annotation is set.
210210
func (nt *nodeTracker) updateNode(node *corev1.Node) {
211-
klog.V(2).Infof("Processing possible switch / router updates for node %s", node.Name)
211+
klog.V(2).Infof("Processing possible switch / router updates for node %s in network %q", node.Name, nt.netInfo.GetNetworkName())
212212
var hsn []*net.IPNet
213213
var err error
214214
if nt.netInfo.TopologyType() == types.Layer2Topology {

0 commit comments

Comments
 (0)