Skip to content
This repository was archived by the owner on Aug 29, 2018. It is now read-only.

Commit 9d6cc20

Browse files
committed
Remove all use of params subclass that point to items provided in RHEL6
I've left in scl related params as I can envision those possibly changing the future. The rest all point to RHEL6 items that I think we can be sure won't change.
1 parent 4e69adb commit 9d6cc20

File tree

10 files changed

+14
-54
lines changed

10 files changed

+14
-54
lines changed

manifests/avahi.pp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
# limitations under the License.
1515
#
1616
class openshift_origin::avahi {
17-
include openshift_origin::params
18-
1917
# TODO: Farm work out to Avahi module
2018

2119
package { ['avahi-cname-manager']:

manifests/broker.pp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@
240240

241241
exec { 'Broker gem dependencies':
242242
cwd => '/var/www/openshift/broker/',
243-
command => "${::openshift_origin::params::rm} -f Gemfile.lock && ${broker_bundle_show}",
243+
command => "rm -f Gemfile.lock && ${broker_bundle_show}",
244244
before => File['/var/www/openshift/broker/tmp'],
245245
require => [
246246
Package['openshift-origin-broker'],

manifests/console.pp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,12 +127,12 @@
127127

128128
exec { 'Console gem dependencies':
129129
cwd => '/var/www/openshift/console/',
130-
command => "${::openshift_origin::params::rm} -f Gemfile.lock && \
130+
command => "rm -f Gemfile.lock && \
131131
${console_bundle_show} && \
132-
${::openshift_origin::params::chown} apache:apache Gemfile.lock && \
133-
${::openshift_origin::params::rm} -rf tmp/cache/* && \
132+
chown apache:apache Gemfile.lock && \
133+
rm -rf tmp/cache/* && \
134134
${console_asset_rake_cmd} && \
135-
${::openshift_origin::params::chown} -R apache:apache /var/www/openshift/console",
135+
chown -R apache:apache /var/www/openshift/console",
136136
require => Package['openshift-origin-console','httpd'],
137137
subscribe => [
138138
Package['openshift-origin-console'],

manifests/install_method.pp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@
1313
# limitations under the License.
1414
#
1515
class openshift_origin::install_method {
16-
include openshift_origin::params
17-
1816
stage { 'first':
1917
before => Stage['main'],
2018
}

manifests/msgserver.pp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@
1616
class openshift_origin::msgserver (
1717
$using_systemd = false
1818
) {
19-
include openshift_origin::params
20-
2119
anchor { 'openshift_origin::msgserver_begin': } ->
2220
class { 'openshift_origin::firewall::activemq': } ->
2321
anchor { 'openshift_origin::msgserver_end': }

manifests/nameserver.pp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
# limitations under the License.
1515
#
1616
class openshift_origin::nameserver {
17-
include openshift_origin::params
18-
1917
anchor { 'openshift_origin::nameserver_begin': } ->
2018
class { 'openshift_origin::firewall::dns': } ->
2119
anchor {'openshift_origin::nameserver_end': }

manifests/params.pp

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -14,34 +14,6 @@
1414
# limitations under the License.
1515
#
1616
class openshift_origin::params {
17-
$rm = $::operatingsystem ? {
18-
default => '/bin/rm',
19-
}
20-
21-
$chown = $::operatingsystem ? {
22-
default => '/bin/chown',
23-
}
24-
25-
$httxt2dbm = $::operatingsystem ? {
26-
default => '/usr/sbin/httxt2dbm',
27-
}
28-
29-
$chmod = $::operatingsystem ? {
30-
default => '/bin/chmod',
31-
}
32-
33-
$grep = $::operatingsystem ? {
34-
default => '/bin/grep',
35-
}
36-
37-
$cat = $::operatingsystem ? {
38-
default => '/bin/cat',
39-
}
40-
41-
$mv = $::operatingsystem ? {
42-
default => '/bin/mv',
43-
}
44-
4517
$ruby_scl_prefix = $::operatingsystem ? {
4618
default => 'ruby193-',
4719
}
@@ -50,10 +22,6 @@
5022
default => '/opt/rh/ruby193/root',
5123
}
5224

53-
$sysctl = $::operatingsystem ? {
54-
default => '/sbin/sysctl',
55-
}
56-
5725
$node_shmmax = $::architecture ? {
5826
'x86_64' => 68719476736,
5927
default => 33554432,

manifests/plugins/frontend/apache_mod_rewrite.pp

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
# limitations under the License.
1515
#
1616
class openshift_origin::plugins::frontend::apache_mod_rewrite {
17-
include ::openshift_origin::params
1817
include openshift_origin::plugins::frontend::apache
1918

2019
anchor { 'openshift_origin::plugins::fronted::apache_mod_rewrite_begin': } ->
@@ -39,13 +38,13 @@
3938
}
4039

4140
exec { 'regen node routes':
42-
command => "${::openshift_origin::params::cat} /etc/httpd/conf.d/openshift/nodes.txt /tmp/nodes.broker_routes.txt > /etc/httpd/conf.d/openshift/nodes.txt.new && \
43-
${::openshift_origin::params::mv} /etc/httpd/conf.d/openshift/nodes.txt.new /etc/httpd/conf.d/openshift/nodes.txt && \
44-
${::openshift_origin::params::httxt2dbm} -f DB -i /etc/httpd/conf.d/openshift/nodes.txt -o /etc/httpd/conf.d/openshift/nodes.db.new && \
45-
${::openshift_origin::params::chown} root:apache /etc/httpd/conf.d/openshift/nodes.txt /etc/httpd/conf.d/openshift/nodes.db.new && \
46-
${::openshift_origin::params::chmod} 750 /etc/httpd/conf.d/openshift/nodes.txt /etc/httpd/conf.d/openshift/nodes.db.new && \
47-
${::openshift_origin::params::mv} -f /etc/httpd/conf.d/openshift/nodes.db.new /etc/httpd/conf.d/openshift/nodes.db",
48-
unless => "${::openshift_origin::params::grep} '__default__/broker' /etc/httpd/conf.d/openshift/nodes.txt 2>/dev/null",
41+
command => "cat /etc/httpd/conf.d/openshift/nodes.txt /tmp/nodes.broker_routes.txt > /etc/httpd/conf.d/openshift/nodes.txt.new && \
42+
mv /etc/httpd/conf.d/openshift/nodes.txt.new /etc/httpd/conf.d/openshift/nodes.txt && \
43+
httxt2dbm -f DB -i /etc/httpd/conf.d/openshift/nodes.txt -o /etc/httpd/conf.d/openshift/nodes.db.new && \
44+
chown root:apache /etc/httpd/conf.d/openshift/nodes.txt /etc/httpd/conf.d/openshift/nodes.db.new && \
45+
chmod 750 /etc/httpd/conf.d/openshift/nodes.txt /etc/httpd/conf.d/openshift/nodes.db.new && \
46+
mv -f /etc/httpd/conf.d/openshift/nodes.db.new /etc/httpd/conf.d/openshift/nodes.db",
47+
unless => "grep '__default__/broker' /etc/httpd/conf.d/openshift/nodes.txt 2>/dev/null",
4948
require => File['broker and console route for node'],
5049
}
5150
}

manifests/role.pp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
# limitations under the License.
1515
#
1616
class openshift_origin::role {
17-
include openshift_origin::params
1817
include openshift_origin::install_method
1918
require openshift_origin::firewall::ssh
2019

templates/console/console.conf.erb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,8 @@ REMOTE_USER_COPY_HEADERS=X-Remote-User
132132

133133
#GITHUB_ORIGIN_SERVER_REPO=origin-server
134134

135+
#ORIGIN_SERVER_SRPM_URL=http://mirror.openshift.com/pub/openshift-origin/nightly/rhel-6/latest/SRPMS/
136+
135137
#RED_HAT_ACCOUNT_URL=https://www.redhat.com/wapps/ugc
136138

137139

0 commit comments

Comments
 (0)