Skip to content

Commit 2b55092

Browse files
committed
Fix HNS network removal error log level
A failure to remove an HNS network is a recoverable error, and should be logged at debug level. This commit fixes an issue where this being logged at info level. log.V(1).Info needs to be used to log to debug level. log.V(1).Error does not work. logger.Error has the documentation: "The log message will always be emitted, regardless of verbosity level"
1 parent b593ed7 commit 2b55092

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pkg/windows/windows.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -970,7 +970,7 @@ func (vm *windows) ensureHNSNetworksAreRemoved() error {
970970
err = wait.PollImmediate(retry.Interval, retry.Timeout, func() (bool, error) {
971971
// reinitialize and retry on failure to avoid connection reset SSH errors
972972
if err := vm.removeHNSNetwork(network); err != nil {
973-
vm.log.V(1).Error(err, "error removing %s HNS network", "network", network)
973+
vm.log.V(1).Info("error removing HNS network", "network", network, "err", err.Error())
974974
if err := vm.reinitialize(); err != nil {
975975
return false, fmt.Errorf("error reinitializing VM after removing %s HNS network: %w", network, err)
976976
}
@@ -981,7 +981,7 @@ func (vm *windows) ensureHNSNetworksAreRemoved() error {
981981
}
982982
out, err := vm.Run(getHNSNetworkCmd(network), true)
983983
if err != nil {
984-
vm.log.V(1).Error(err, "error waiting for HNS network", "network", network)
984+
vm.log.V(1).Info("error waiting for HNS network", "network", network, "err", err.Error())
985985
return false, nil
986986
}
987987
return !strings.Contains(out, network), nil

0 commit comments

Comments
 (0)