Skip to content

Commit 35ab0d5

Browse files
authored
Merge pull request #2595 from opensim-org/opensense_coordinatedirection
Use CoordinateDirection rather than CoordinateAxis
2 parents 2eeed99 + b04e275 commit 35ab0d5

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

OpenSim/Simulation/OpenSense/OpenSenseUtilities.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ Model OpenSenseUtilities::calibrateModelFromOrientations(
123123
const string& modelCalibrationPoseFile,
124124
const string& calibrationOrientationsFile,
125125
const std::string& baseImuName,
126-
const SimTK::CoordinateAxis& baseHeadingAxis,
126+
const SimTK::CoordinateDirection& baseHeadingDirection,
127127
bool visualizeCalibratedModel)
128128
{
129129
Model model(modelCalibrationPoseFile);
@@ -135,7 +135,7 @@ Model OpenSenseUtilities::calibrateModelFromOrientations(
135135

136136
TimeSeriesTable_<SimTK::Rotation> orientationsData =
137137
OpenSenseUtilities::convertQuaternionsToRotations(quatTable,
138-
startEnd, baseImuName, baseHeadingAxis);
138+
startEnd, baseImuName, baseHeadingDirection);
139139

140140
std::cout << "Loaded orientations as quaternions from "
141141
<< calibrationOrientationsFile << std::endl;

OpenSim/Simulation/OpenSense/OpenSenseUtilities.h

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,9 @@ namespace OpenSim {
7070
to account for the heading difference between the sensor
7171
data and the forward direction of the model. Leave blank
7272
if no heading correction is to be applied.
73-
baseHeadingAxis: The axis of the base IMU that corresponds to its
74-
heading direction. Options are SimTK::X/Y/ZAxis
73+
baseHeadingDirection: The axis of the base IMU that corresponds to its
74+
heading direction. Options are SimTK::X/Y/ZAxis, along with
75+
direction of +1/-1
7576
Assumptions about the inputs:
7677
1) the model default pose is the same as the pose used to collect
7778
calibration data
@@ -84,7 +85,7 @@ namespace OpenSim {
8485
const std::string& modelCalibrationPoseFile,
8586
const std::string& calibrationOrientationsFile,
8687
const std::string& baseImuName = "",
87-
const SimTK::CoordinateAxis& baseHeadingAxis = SimTK::ZAxis,
88+
const SimTK::CoordinateDirection& baseHeadingDirection =SimTK::ZAxis,
8889
bool visualizeCalibratedModel =true);
8990
/**
9091
* Create Orientations as a TimeSeriesTable based on passed in markerFile

0 commit comments

Comments
 (0)