Skip to content

Commit af28d78

Browse files
committed
Address feedback on PR, in particular property comments, variable names
1 parent c333c2a commit af28d78

File tree

3 files changed

+11
-8
lines changed

3 files changed

+11
-8
lines changed

OpenSim/Tools/InverseKinematicsTool.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -162,11 +162,11 @@ bool InverseKinematicsTool::run()
162162
// specified then use time from marker reference.
163163
// Adjust the time range for the tool if the provided range exceeds
164164
// that of the marker data.
165-
SimTK::Vec2 markersValidTimRange = markersReference.getValidTimeRange();
166-
double start_time = (markersValidTimRange[0] > get_time_range(0)) ?
167-
markersValidTimRange[0] : get_time_range(0);
168-
double final_time = (markersValidTimRange[1] < get_time_range(1)) ?
169-
markersValidTimRange[1] : get_time_range(1);
165+
SimTK::Vec2 markersValidTimeRange = markersReference.getValidTimeRange();
166+
double start_time = (markersValidTimeRange[0] > get_time_range(0)) ?
167+
markersValidTimeRange[0] : get_time_range(0);
168+
double final_time = (markersValidTimeRange[1] < get_time_range(1)) ?
169+
markersValidTimeRange[1] : get_time_range(1);
170170

171171
SimTK_ASSERT2_ALWAYS(final_time >= start_time,
172172
"InverseKinematicsTool final time (%f) is before start time (%f).",

OpenSim/Tools/InverseKinematicsTool.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,15 +77,17 @@ OpenSim_DECLARE_CONCRETE_OBJECT(InverseKinematicsTool, Tool);
7777

7878
OpenSim_DECLARE_PROPERTY(accuracy, double,
7979
"The accuracy of the solution in absolute terms, i.e. the number of "
80-
"significant digits to which the solution can be trusted. Default 1e-6.");
80+
"significant digits to which the solution can be trusted. Default 1e-5.");
8181

8282
OpenSim_DECLARE_UNNAMED_PROPERTY(
8383
IKTaskSet,
8484
"Markers and coordinates to be considered (tasks) and their weightings. "
8585
"The sum of weighted-squared task errors composes the cost function.");
8686

8787
OpenSim_DECLARE_PROPERTY(marker_file, std::string,
88-
"Name/path to a .trc or .sto file of type Vec3 of marker data.");
88+
"TRC file (.trc) containing the time history of observations of marker "
89+
"positions obtained during a motion capture experiment. Markers in this "
90+
"file that have a corresponding task and model marker are included."");
8991
9092
9193
OpenSim_DECLARE_PROPERTY(coordinate_file, std::string,

OpenSim/Tools/Tool.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,8 @@ OpenSim_DECLARE_ABSTRACT_OBJECT(Tool, Object);
7373
/**
7474
* Default constructor.
7575
*/
76-
Tool() { constructProperties();
76+
Tool() {
77+
constructProperties();
7778
};
7879

7980
/**

0 commit comments

Comments
 (0)