Changed the initial guess to max otherwise it greatly overestimate the values

pariterre · pariterre · commit d843b484e3a5 · 2023-03-03T11:23:11.000-05:00
diff --git a/OpenSim/Analyses/StaticOptimization.cpp b/OpenSim/Analyses/StaticOptimization.cpp
@@ -593,9 +593,9 @@ int StaticOptimization::begin(const SimTK::State& s )
             ScalarActuator* act = dynamic_cast<ScalarActuator*>(&fs.get(i));
             if (act) {
                 if (act->getMinControl() != -INFINITY)
-                    _parameters[j++] = act->getMinControl();
+                    _parameters[j++] = act->getMaxControl();
                 else
-                    _parameters[j++] = 0.;
+                    _parameters[j++] = 1.;
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -593,9 +593,9 @@ int StaticOptimization::begin(const SimTK::State& s )`
`593`	`593`	`ScalarActuator* act = dynamic_cast<ScalarActuator*>(&fs.get(i));`
`594`	`594`	`if (act) {`
`595`	`595`	`if (act->getMinControl() != -INFINITY)`
`596`		`- _parameters[j++] = act->getMinControl();`
	`596`	`+ _parameters[j++] = act->getMaxControl();`
`597`	`597`	`else`
`598`		`- _parameters[j++] = 0.;`
	`598`	`+ _parameters[j++] = 1.;`
`599`	`599`	`}`
`600`	`600`	`}`
`601`	`601`	`}`