Merge pull request #123 from mahone3297/dev_assign_of_new_by_reference

[bug fix] assigning the reurn value of new by referece is now deprecated.

Author: slde-robin

src/Visitor/Usage/FindLanguageDeprecations.php

@@ -32,9 +32,9 @@ public function setPhpFileInfo(PhpFileInfo $phpFileInfo)
      */
     public function enterNode(Node $node)
     {
-        if ($node instanceof Node\Expr\AssignRef) {
+        if ($node instanceof Node\Expr\AssignRef && $node->expr instanceof Node\Expr\New_) {
             $this->phpFileInfo->addDeprecatedLanguageUsage(
-                new DeprecatedLanguageUsage('assign by reference(&=)', 'Since PHP 5.3 use normal assignment instead.', $node->getLine())
+                new DeprecatedLanguageUsage('Assigning the return value of new by reference is now deprecated.', 'Since PHP 5.3 use normal assignment instead.', $node->getLine())
             );
         }
 

tests/Visitor/Usage/FindLanguageDeprecationsTest.php

@@ -0,0 +1,55 @@
+<?php
+
+namespace SensioLabs\DeprecationDetector\Tests\Visitor\Usage;
+
+use SensioLabs\DeprecationDetector\FileInfo\PhpFileInfo;
+use SensioLabs\DeprecationDetector\FileInfo\Usage\DeprecatedLanguageUsage;
+use SensioLabs\DeprecationDetector\Visitor\Usage\FindLanguageDeprecations;
+
+class FindLanguageDeprecationsTest extends FindTestCase
+{
+    // http://php.net/manual/en/migration53.deprecated.php
+    public function testAssignOfNewByReference()
+    {
+        $source = <<<'EOC'
+<?php
+
+$foo =& new Foo();
+
+EOC;
+        $splFileInfo = $this->prophesize('Symfony\Component\Finder\SplFileInfo');
+        $phpFileInfo = $this->parsePhpFileFromStringAndTraverseWithVisitor(
+            $file = PhpFileInfo::create($splFileInfo->reveal()),
+            $source,
+            new FindLanguageDeprecations()
+        );
+
+        $this->assertEquals(
+            array(
+                new DeprecatedLanguageUsage('Assigning the return value of new by reference is now deprecated.', 'Since PHP 5.3 use normal assignment instead.', 3),
+            ),
+            $phpFileInfo->getDeprecatedLanguageUsages()
+        );
+    }
+
+    public function testAssignByReference()
+    {
+        $source = <<<'EOC'
+<?php
+
+$foo =& $bar;
+
+EOC;
+        $splFileInfo = $this->prophesize('Symfony\Component\Finder\SplFileInfo');
+        $phpFileInfo = $this->parsePhpFileFromStringAndTraverseWithVisitor(
+            $file = PhpFileInfo::create($splFileInfo->reveal()),
+            $source,
+            new FindLanguageDeprecations()
+        );
+
+        $this->assertEquals(
+            array(),
+            $phpFileInfo->getDeprecatedLanguageUsages()
+        );
+    }
+}