[#133] Avoids false positives on seudo PHP4 constructor methods.

Author: jcchavezs

src/Visitor/Usage/FindLanguageDeprecations.php

@@ -40,7 +40,7 @@ public function enterNode(Node $node)
 
         if ($node instanceof Node\Stmt\Class_) {
             $method = $node->getMethod($node->name);
-            if ($method instanceof Node\Stmt\ClassMethod) {
+            if ($method instanceof Node\Stmt\ClassMethod && count($node->namespacedName->parts) === 1) {
                 $this->phpFileInfo->addDeprecatedLanguageUsage(
                     new DeprecatedLanguageUsage(
                         'PHP4 constructor',

tests/Visitor/Usage/FindLanguageDeprecationsTest.php

@@ -15,6 +15,62 @@ public function testAssignByReference()
 
 $foo =& $bar;
 
+EOC;
+        $splFileInfo = $this->prophesize('Symfony\Component\Finder\SplFileInfo');
+        $phpFileInfo = $this->parsePhpFileFromStringAndTraverseWithVisitor(
+            $file = PhpFileInfo::create($splFileInfo->reveal()),
+            $source,
+            new FindLanguageDeprecations()
+        );
+
+        $this->assertEquals(
+            array(),
+            $phpFileInfo->getDeprecatedLanguageUsages()
+        );
+    }
+
+    public function testPHP4Constructors()
+    {
+        $source = <<<'EOC'
+<?php
+
+class OddClass
+{
+    public function oddClass()
+    {
+        return null;
+    }
+}
+
+EOC;
+        $splFileInfo = $this->prophesize('Symfony\Component\Finder\SplFileInfo');
+        $phpFileInfo = $this->parsePhpFileFromStringAndTraverseWithVisitor(
+            $file = PhpFileInfo::create($splFileInfo->reveal()),
+            $source,
+            new FindLanguageDeprecations()
+        );
+
+        $this->assertInstanceOf(
+            'SensioLabs\DeprecationDetector\FileInfo\Usage\DeprecatedLanguageUsage',
+            $phpFileInfo->getDeprecatedLanguageUsages()[0]
+        );
+    }
+
+    public function testNamespacedPHP4Constructors()
+    {
+        $source = <<<'EOC'
+<?php
+
+namespace Name\Space;
+
+class OddClass
+{
+    public function oddClass()
+    {
+        return null;
+    }
+}
+
 EOC;
         $splFileInfo = $this->prophesize('Symfony\Component\Finder\SplFileInfo');
         $phpFileInfo = $this->parsePhpFileFromStringAndTraverseWithVisitor(