Skip to content

Commit 0e418d5

Browse files
committed
add CI jobs for Symfony 7.3
1 parent f367563 commit 0e418d5

File tree

2 files changed

+19
-2
lines changed

2 files changed

+19
-2
lines changed

.github/workflows/ci.yaml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,9 @@ jobs:
6969
- php-version: '8.2'
7070
composer-options: '--prefer-stable'
7171
symfony-version: '7.2.*'
72+
- php-version: '8.2'
73+
composer-options: '--prefer-stable'
74+
symfony-version: '7.3.*'
7275
- php-version: '8.3'
7376
composer-options: '--prefer-stable'
7477
symfony-version: '6.4.*'
@@ -78,6 +81,9 @@ jobs:
7881
- php-version: '8.3'
7982
composer-options: '--prefer-stable'
8083
symfony-version: '7.2.*'
84+
- php-version: '8.3'
85+
composer-options: '--prefer-stable'
86+
symfony-version: '7.3.*'
8187
- php-version: '8.4'
8288
composer-options: '--prefer-stable'
8389
symfony-version: '6.4.*'
@@ -87,6 +93,9 @@ jobs:
8793
- php-version: '8.4'
8894
composer-options: '--prefer-stable'
8995
symfony-version: '7.2.*'
96+
- php-version: '8.4'
97+
composer-options: '--prefer-stable'
98+
symfony-version: '7.3.*'
9099

91100
steps:
92101
- name: 'Check out'

tests/Fixtures/DependencyInjection/Kernel.php

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
namespace Qossmic\RichModelForms\Tests\Fixtures\DependencyInjection;
1717

1818
use Qossmic\RichModelForms\RichModelFormsBundle;
19+
use Symfony\Bundle\FrameworkBundle\Command\TranslationExtractCommand;
1920
use Symfony\Bundle\FrameworkBundle\FrameworkBundle;
2021
use Symfony\Component\Config\Loader\LoaderInterface;
2122
use Symfony\Component\DependencyInjection\Compiler\PassConfig;
@@ -37,13 +38,20 @@ public function registerContainerConfiguration(LoaderInterface $loader): void
3738
$loader->load(function (ContainerBuilder $container): void {
3839
$container->addCompilerPass(new PublicTestAliasPass(), PassConfig::TYPE_BEFORE_OPTIMIZATION, 1000);
3940
$container->setParameter('kernel.secret', __FILE__);
40-
$container->loadFromExtension('framework', [
41+
42+
$frameworkConfig = [
4143
'handle_all_throwables' => false,
4244
'http_method_override' => false,
4345
'php_errors' => [
4446
'log' => false,
4547
],
46-
]);
48+
];
49+
50+
if (class_exists(TranslationExtractCommand::class)) {
51+
$frameworkConfig['property_info']['with_constructor_extractor'] = true;
52+
}
53+
54+
$container->loadFromExtension('framework', $frameworkConfig);
4755
});
4856
}
4957

0 commit comments

Comments
 (0)