feature #119 add property type hints (xabbuh)

This PR was merged into the 0.2-dev branch.

Discussion
----------

add property type hints

Commits
-------

f1f1c21 add property type hints

Author: xabbuh

src/Qossmic/DataMapper/DataMapper.php

@@ -28,9 +28,9 @@
  */
 class DataMapper implements DataMapperInterface
 {
-    private $dataMapper;
-    private $propertyAccessor;
-    private $formExceptionHandler;
+    private DataMapperInterface $dataMapper;
+    private PropertyAccessorInterface $propertyAccessor;
+    private FormExceptionHandler $formExceptionHandler;
 
     public function __construct(DataMapperInterface $dataMapper, PropertyAccessorInterface $propertyAccessor, FormExceptionHandler $formExceptionHandler)
     {

src/Qossmic/DataTransformer/ValueObjectTransformer.php

@@ -30,8 +30,8 @@ class ValueObjectTransformer implements DataTransformerInterface
 {
     use ExceptionToErrorMapperTrait;
 
-    private $propertyAccessor;
-    private $form;
+    private PropertyAccessorInterface $propertyAccessor;
+    private FormBuilderInterface $form;
 
     public function __construct(ExceptionHandlerRegistry $exceptionHandlerRegistry, PropertyAccessorInterface $propertyAccessor, FormBuilderInterface $form)
     {
@@ -43,7 +43,7 @@ public function __construct(ExceptionHandlerRegistry $exceptionHandlerRegistry,
     /**
      * @param mixed $value
      *
-     * @return string|array<string,string>|null
+     * @return array<string,bool|int|string|null>|bool|int|string|null
      */
     public function transform($value)
     {
@@ -73,10 +73,7 @@ public function transform($value)
         return $this->getPropertyValue($this->form, $value);
     }
 
-    /**
-     * @return object
-     */
-    public function reverseTransform($value)
+    public function reverseTransform($value): object
     {
         try {
             return (new ViewDataInstantiator($this->form, $value))->instantiateObject();
@@ -92,11 +89,9 @@ public function reverseTransform($value)
     }
 
     /**
-     * @param object $object
-     *
-     * @return string
+     * @return bool|int|string|null
      */
-    private function getPropertyValue(FormBuilderInterface $form, $object)
+    private function getPropertyValue(FormBuilderInterface $form, object $object)
     {
         if (null !== $form->getPropertyPath()) {
             return $this->propertyAccessor->getValue($object, $form->getPropertyPath());

src/Qossmic/ExceptionHandling/ChainExceptionHandler.php

@@ -31,7 +31,7 @@
  */
 class ChainExceptionHandler implements ExceptionHandlerInterface
 {
-    private $exceptionHandlers;
+    private iterable $exceptionHandlers;
 
     /**
      * @param ExceptionHandlerInterface[] $exceptionHandlers

src/Qossmic/ExceptionHandling/Error.php

@@ -21,9 +21,9 @@
  */
 class Error
 {
-    private $cause;
-    private $messageTemplate;
-    private $parameters;
+    private \Throwable $cause;
+    private string $messageTemplate;
+    private array $parameters;
 
     public function __construct(\Throwable $cause, string $messageTemplate, array $parameters = [])
     {

src/Qossmic/ExceptionHandling/ExceptionHandlerRegistry.php

@@ -21,9 +21,13 @@
  */
 class ExceptionHandlerRegistry
 {
-    private $container;
-    private $strategies;
+    private ContainerInterface $container;
+    /** @var array<string,string> */
+    private array $strategies;
 
+    /**
+     * @param array<string,string> $strategies
+     */
     public function __construct(ContainerInterface $container, array $strategies)
     {
         $this->container = $container;

src/Qossmic/ExceptionHandling/ExceptionToErrorMapperTrait.php

@@ -23,7 +23,7 @@
  */
 trait ExceptionToErrorMapperTrait
 {
-    private $exceptionHandlerRegistry;
+    private ExceptionHandlerRegistry $exceptionHandlerRegistry;
 
     /**
      * @param mixed $data

src/Qossmic/ExceptionHandling/FormExceptionHandler.php

@@ -25,8 +25,8 @@ class FormExceptionHandler
 {
     use ExceptionToErrorMapperTrait;
 
-    private $translator;
-    private $translationDomain;
+    private ?TranslatorInterface $translator;
+    private ?string $translationDomain;
 
     public function __construct(ExceptionHandlerRegistry $exceptionHandlerRegistry, TranslatorInterface $translator = null, string $translationDomain = null)
     {

src/Qossmic/ExceptionHandling/GenericExceptionHandler.php

@@ -32,8 +32,12 @@
  */
 class GenericExceptionHandler implements ExceptionHandlerInterface
 {
-    private $handledExceptionClass;
+    /** @var class-string */
+    private string $handledExceptionClass;
 
+    /**
+     * @param class-string $handledExceptionClass
+     */
     public function __construct(string $handledExceptionClass)
     {
         $this->handledExceptionClass = $handledExceptionClass;

src/Qossmic/Extension/RichModelFormsTypeExtension.php

@@ -36,9 +36,9 @@
  */
 class RichModelFormsTypeExtension extends AbstractTypeExtension
 {
-    private $propertyAccessor;
-    private $exceptionHandlerRegistry;
-    private $formExceptionHandler;
+    private PropertyAccessorInterface $propertyAccessor;
+    private ExceptionHandlerRegistry $exceptionHandlerRegistry;
+    private FormExceptionHandler $formExceptionHandler;
 
     public function __construct(PropertyAccessorInterface $propertyAccessor, ExceptionHandlerRegistry $exceptionHandlerRegistry, FormExceptionHandler $formExceptionHandler)
     {

src/Qossmic/Instantiator/FormDataInstantiator.php

@@ -21,8 +21,9 @@
  */
 class FormDataInstantiator extends ObjectInstantiator
 {
-    private $form;
-    private $formNameForArgument;
+    private FormInterface $form;
+    /** @var array<string,string> */
+    private array $formNameForArgument;
 
     /**
      * @param class-string|\Closure|(callable&array) $factory
@@ -34,7 +35,7 @@ public function __construct($factory, FormInterface $form)
         $this->form = $form;
         $this->formNameForArgument = [];
 
-        foreach ($form as $name => $child) {
+        foreach ($form as $child) {
             $this->formNameForArgument[$child->getConfig()->getOption('factory_argument') ?? $child->getName()] = $child->getName();
         }
     }