minor #122 use PhpStan 1.x (xabbuh)

This PR was merged into the 0.2-dev branch.

Discussion
----------

use PhpStan 1.x

Commits
-------

6bd4524 use PhpStan 1.x

Author: xabbuh

composer.json

@@ -27,7 +27,7 @@
     },
     "require-dev": {
         "friendsofphp/php-cs-fixer": "^3.4",
-        "phpstan/phpstan": "^0.12.4",
+        "phpstan/phpstan": "^1.7.11",
         "symfony/phpunit-bridge": "^4.4.12||^5.4",
         "symfony/translation": "^4.4||^5.4||^6.0"
     },

src/Qossmic/DataMapper/DataMapper.php

@@ -61,8 +61,10 @@ public function mapDataToForms($data, $forms): void
             if (!$isDataEmpty && $readPropertyPath instanceof \Closure && $form->getConfig()->getMapped()) {
                 $form->setData($readPropertyPath($data));
             } elseif (!$isDataEmpty && null !== $readPropertyPath && $form->getConfig()->getMapped()) {
+                /* @phpstan-ignore-next-line */
                 $form->setData($this->propertyAccessor->getValue($data, $readPropertyPath));
             } elseif (!$isDataEmpty && null !== $propertyMapper) {
+                /* @phpstan-ignore-next-line */
                 $form->setData($propertyMapper->readPropertyValue($data));
             } elseif (null !== $readPropertyPath) {
                 $form->setData($form->getConfig()->getData());
@@ -102,8 +104,10 @@ public function mapFormsToData($forms, &$data): void
             if ($readPropertyPath instanceof \Closure) {
                 $previousValue = $readPropertyPath($data);
             } elseif (null !== $readPropertyPath) {
+                /* @phpstan-ignore-next-line */
                 $previousValue = $this->propertyAccessor->getValue($data, $readPropertyPath);
             } elseif (null !== $propertyMapper) {
+                /* @phpstan-ignore-next-line */
                 $previousValue = $propertyMapper->readPropertyValue($data);
             } else {
                 $previousValue = null;

src/Qossmic/DataTransformer/ValueObjectTransformer.php

@@ -41,7 +41,7 @@ public function __construct(ExceptionHandlerRegistry $exceptionHandlerRegistry,
     }
 
     /**
-     * @param mixed $value
+     * @param object|null $value
      *
      * @return array<string,bool|int|string|null>|bool|int|string|null
      */
@@ -76,6 +76,7 @@ public function transform($value)
     public function reverseTransform($value): ?object
     {
         try {
+            /* @phpstan-ignore-next-line */
             return (new ViewDataInstantiator($this->form, $value))->instantiateObject();
         } catch (\Throwable $e) {
             $error = $this->mapExceptionToError($this->form, $value, $e);
@@ -94,6 +95,7 @@ public function reverseTransform($value): ?object
     private function getPropertyValue(FormBuilderInterface $form, object $object)
     {
         if (null !== $form->getPropertyPath()) {
+            /* @phpstan-ignore-next-line */
             return $this->propertyAccessor->getValue($object, $form->getPropertyPath());
         }
 
@@ -103,6 +105,7 @@ private function getPropertyValue(FormBuilderInterface $form, object $object)
             return $readPropertyPath($object);
         }
 
+        /* @phpstan-ignore-next-line */
         return $this->propertyAccessor->getValue($object, $readPropertyPath);
     }
 }

src/Qossmic/ExceptionHandling/ExceptionHandlerRegistry.php

@@ -45,6 +45,7 @@ public function get(string $strategy): ExceptionHandlerInterface
             throw new \InvalidArgumentException(sprintf('The exception handling strategy "%s" is not registered (use one of ["%s"]).', $strategy, implode(', ', array_keys($this->strategies))));
         }
 
+        /* @phpstan-ignore-next-line */
         return $this->container->get($this->strategies[$strategy]);
     }
 }

src/Qossmic/ExceptionHandling/ExceptionToErrorMapperTrait.php

@@ -33,13 +33,17 @@ private function mapExceptionToError(FormConfigInterface $formConfig, $data, \Th
         $exceptionHandlers = [];
 
         if (null !== $formConfig->getOption('handle_exception')) {
+            /* @phpstan-ignore-next-line */
             foreach ($formConfig->getOption('handle_exception') as $exceptionClass) {
+                /* @phpstan-ignore-next-line */
                 $exceptionHandlers[] = new GenericExceptionHandler($exceptionClass);
             }
 
             $exceptionHandlers[] = $this->exceptionHandlerRegistry->get('type_error');
         } else {
+            /* @phpstan-ignore-next-line */
             foreach ($formConfig->getOption('exception_handling_strategy') as $strategy) {
+                /* @phpstan-ignore-next-line */
                 $exceptionHandlers[] = $this->exceptionHandlerRegistry->get($strategy);
             }
         }

src/Qossmic/ExceptionHandling/FallbackExceptionHandler.php

@@ -38,6 +38,7 @@ public function getError(FormConfigInterface $formConfig, $data, \Throwable $e):
         $messageTemplate = $formConfig->getOption('invalid_message') ?? 'This value is not valid.';
         $parameters = $formConfig->getOption('invalid_message_parameters') ?? [];
 
+        /* @phpstan-ignore-next-line */
         return new Error($e, $messageTemplate, $parameters);
     }
 }

src/Qossmic/Extension/RichModelFormsTypeExtension.php

@@ -177,6 +177,7 @@ public function configureOptions(OptionsResolver $resolver): void
                     }
 
                     try {
+                        /* @phpstan-ignore-next-line */
                         return (new FormDataInstantiator($options['factory'], $form))->instantiateObject();
                     } catch (\Throwable $e) {
                         $this->formExceptionHandler->handleException($form, $form->getData(), $e);

src/Qossmic/Instantiator/FormDataInstantiator.php

@@ -36,6 +36,7 @@ public function __construct($factory, FormInterface $form)
         $this->formNameForArgument = [];
 
         foreach ($form as $child) {
+            /* @phpstan-ignore-next-line */
             $this->formNameForArgument[$child->getConfig()->getOption('factory_argument') ?? $child->getName()] = $child->getName();
         }
     }

src/Qossmic/Instantiator/ObjectInstantiator.php

@@ -54,6 +54,7 @@ public function instantiateObject(): ?object
         } elseif ($this->factory instanceof \Closure) {
             $factoryMethod = new \ReflectionFunction($this->factory);
         } else {
+            /* @phpstan-ignore-next-line */
             return $this->getData();
         }
 

src/Qossmic/Instantiator/ViewDataInstantiator.php

@@ -32,13 +32,15 @@ class ViewDataInstantiator extends ObjectInstantiator
      */
     public function __construct(FormBuilderInterface $form, $viewData)
     {
+        /* @phpstan-ignore-next-line */
         parent::__construct($form->getFormConfig()->getOption('factory'));
 
         $this->form = $form;
         $this->viewData = $viewData;
         $this->formNameForArgument = [];
 
         foreach ($form as $child) {
+            /* @phpstan-ignore-next-line */
             $this->formNameForArgument[$child->getOption('factory_argument') ?? $child->getName()] = $child->getName();
         }
     }