minor #157 use PHPStan 2 (xabbuh)

This PR was merged into the 0.4-dev branch.

Discussion
----------

use PHPStan 2

Commits
-------

5828faa use PHPStan 2

Author: xabbuh

.github/workflows/ci.yaml

@@ -42,12 +42,12 @@ jobs:
 
       - name: 'Install dependencies'
         uses: php-actions/composer@v6
+        with:
+          php_version: '8.1'
 
       - name: 'Run PhpStan'
-        uses: 'php-actions/phpstan@v3'
-        with:
-          configuration: 'phpstan.neon'
-          level: max
+        run: |
+          vendor/bin/phpstan analyze
 
   tests:
     name: 'PHPUnit'

.gitignore

@@ -1,5 +1,6 @@
 /.php-cs-fixer.php
 /.php-cs-fixer.cache
+/phpstan.neon
 /.phpunit.result.cache
 /composer.lock
 /phpunit.xml

composer.json

@@ -26,6 +26,7 @@
         "symfony/property-access": "^6.4||^7.0"
     },
     "require-dev": {
+        "phpstan/phpstan": "^2.1",
         "symfony/phpunit-bridge": "^6.4||^7.0",
         "symfony/translation": "^6.4||^7.0"
     },

phpstan-baseline.neon

@@ -0,0 +1,37 @@
+parameters:
+	ignoreErrors:
+		-
+			message: '#^Parameter \#1 \$objectOrArray of method Symfony\\Component\\PropertyAccess\\PropertyAccessorInterface\:\:setValue\(\) expects array\|object, mixed given\.$#'
+			identifier: argument.type
+			count: 1
+			path: src/Qossmic/DataMapper/DataMapper.php
+
+		-
+			message: '#^Class Qossmic\\RichModelForms\\DataTransformer\\ValueObjectTransformer implements generic interface Symfony\\Component\\Form\\DataTransformerInterface but does not specify its types\: TValue, TTransformedValue$#'
+			identifier: missingType.generics
+			count: 1
+			path: src/Qossmic/DataTransformer/ValueObjectTransformer.php
+
+		-
+			message: '#^Method Qossmic\\RichModelForms\\DataTransformer\\ValueObjectTransformer\:\:getPropertyValue\(\) should return bool\|int\|string\|null but returns mixed\.$#'
+			identifier: return.type
+			count: 1
+			path: src/Qossmic/DataTransformer/ValueObjectTransformer.php
+
+		-
+			message: '#^Cannot access offset ''strategy'' on mixed\.$#'
+			identifier: offsetAccess.nonOffsetAccessible
+			count: 1
+			path: src/Qossmic/DependencyInjection/Compiler/RegisterExceptionHandlersPass.php
+
+		-
+			message: '#^Parameter \#1 \$strategy of method Qossmic\\RichModelForms\\ExceptionHandling\\ExceptionHandlerRegistry\:\:has\(\) expects string, mixed given\.$#'
+			identifier: argument.type
+			count: 1
+			path: src/Qossmic/Extension/RichModelFormsTypeExtension.php
+
+		-
+			message: '#^Parameter \#2 \.\.\.\$values of function sprintf expects bool\|float\|int\|string\|null, mixed given\.$#'
+			identifier: argument.type
+			count: 1
+			path: src/Qossmic/Extension/RichModelFormsTypeExtension.php

phpstan.dist.neon

@@ -0,0 +1,8 @@
+includes:
+	- phpstan-baseline.neon
+
+parameters:
+    inferPrivatePropertyTypeFromConstructor: true
+    level: max
+    paths:
+        - src

phpstan.neon

@@ -30,6 +30,7 @@
  */
 final class ChainExceptionHandler implements ExceptionHandlerInterface
 {
+    /** @var ExceptionHandlerInterface[] */
     private iterable $exceptionHandlers;
 
     /**

src/Qossmic/ExceptionHandling/ChainExceptionHandler.php

@@ -22,8 +22,12 @@ final class Error
 {
     private \Throwable $cause;
     private string $messageTemplate;
+    /** @var array<string, string> */
     private array $parameters;
 
+    /**
+     * @param array<string, string> $parameters
+     */
     public function __construct(\Throwable $cause, string $messageTemplate, array $parameters = [])
     {
         $this->cause = $cause;
@@ -41,6 +45,9 @@ public function getMessageTemplate(): string
         return $this->messageTemplate;
     }
 
+    /**
+     * @return array<string, string>
+     */
     public function getParameters(): array
     {
         return $this->parameters;

src/Qossmic/ExceptionHandling/Error.php

@@ -27,7 +27,7 @@ final class FormDataInstantiator extends ObjectInstantiator
     private array $formNameForArgument;
 
     /**
-     * @param class-string|\Closure|(callable&array) $factory
+     * @param class-string|\Closure|((callable(): object)&array{0: class-string|object, 1: string}) $factory
      */
     public function __construct(string|callable $factory, FormInterface $form)
     {

src/Qossmic/Instantiator/FormDataInstantiator.php

@@ -22,8 +22,12 @@
  */
 abstract class ObjectInstantiator
 {
+    /** @var class-string|(\Closure(): object)|((callable(): object)&array{0: class-string|object, 1: string}) */
     private mixed $factory;
 
+    /**
+     * @param class-string|(\Closure(): object)|((callable(): object)&array{0: class-string|object, 1: string}) $factory
+     */
     public function __construct(mixed $factory)
     {
         $this->factory = $factory;
@@ -42,7 +46,8 @@ public function instantiateObject(): ?object
             if (!$factoryMethod->isPublic()) {
                 throw new TransformationFailedException(\sprintf('The factory method %s() is not public.', $factoryMethodAsString));
             }
-        } elseif (\is_array($this->factory) && \is_callable($this->factory)) {
+        } elseif (\is_array($this->factory)) {
+            /** @var class-string $class */
             $class = \is_object($this->factory[0]) ? \get_class($this->factory[0]) : $this->factory[0];
             $factoryMethod = (new \ReflectionMethod($class, $this->factory[1]));
             $factoryMethodAsString = $class.'::'.$this->factory[1];
@@ -70,6 +75,7 @@ public function instantiateObject(): ?object
             return new $this->factory(...$arguments);
         }
 
+        /* @phpstan-ignore-next-line */
         return ($this->factory)(...$arguments);
     }