Skip to content

Commit a64496e

Browse files
committed
clean up CI jobs, drop jobs for unmaintained Symfony versions
1 parent 753c036 commit a64496e

File tree

2 files changed

+14
-16
lines changed

2 files changed

+14
-16
lines changed

.github/workflows/ci.yaml

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -65,28 +65,19 @@ jobs:
6565
symfony-version: '6.4.*'
6666
- php-version: '8.2'
6767
composer-options: '--prefer-stable'
68-
symfony-version: '7.1.*'
69-
- php-version: '8.2'
70-
composer-options: '--prefer-stable'
71-
symfony-version: '7.2.*'
68+
symfony-version: '7.3.*'
7269
- php-version: '8.3'
7370
composer-options: '--prefer-stable'
7471
symfony-version: '6.4.*'
7572
- php-version: '8.3'
7673
composer-options: '--prefer-stable'
77-
symfony-version: '7.1.*'
78-
- php-version: '8.3'
79-
composer-options: '--prefer-stable'
80-
symfony-version: '7.2.*'
74+
symfony-version: '7.3.*'
8175
- php-version: '8.4'
8276
composer-options: '--prefer-stable'
8377
symfony-version: '6.4.*'
8478
- php-version: '8.4'
8579
composer-options: '--prefer-stable'
86-
symfony-version: '7.1.*'
87-
- php-version: '8.4'
88-
composer-options: '--prefer-stable'
89-
symfony-version: '7.2.*'
80+
symfony-version: '7.3.*'
9081

9182
steps:
9283
- name: 'Check out'

tests/Fixtures/DependencyInjection/Kernel.php

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515

1616
namespace Qossmic\RichModelForms\Tests\Fixtures\DependencyInjection;
1717

18+
use Composer\InstalledVersions;
1819
use Qossmic\RichModelForms\RichModelFormsBundle;
1920
use Symfony\Bundle\FrameworkBundle\FrameworkBundle;
2021
use Symfony\Component\Config\Loader\LoaderInterface;
@@ -35,15 +36,21 @@ public function registerBundles(): array
3536
public function registerContainerConfiguration(LoaderInterface $loader): void
3637
{
3738
$loader->load(function (ContainerBuilder $container): void {
38-
$container->addCompilerPass(new PublicTestAliasPass(), PassConfig::TYPE_BEFORE_OPTIMIZATION, 1000);
39-
$container->setParameter('kernel.secret', __FILE__);
40-
$container->loadFromExtension('framework', [
39+
$frameworkConfig = [
4140
'handle_all_throwables' => false,
4241
'http_method_override' => false,
4342
'php_errors' => [
4443
'log' => false,
4544
],
46-
]);
45+
];
46+
47+
if (version_compare(InstalledVersions::getVersion('symfony/framework-bundle'), '7.3.0', '>=')) {
48+
$frameworkConfig['property_info']['with_constructor_extractor'] = true;
49+
}
50+
51+
$container->addCompilerPass(new PublicTestAliasPass(), PassConfig::TYPE_BEFORE_OPTIMIZATION, 1000);
52+
$container->setParameter('kernel.secret', __FILE__);
53+
$container->loadFromExtension('framework', $frameworkConfig);
4754
});
4855
}
4956

0 commit comments

Comments
 (0)