From 0e418d5f6c024ce0e926070f48e8a713bcaea682 Mon Sep 17 00:00:00 2001 From: Christian Flothmann Date: Mon, 5 May 2025 08:10:28 +0200 Subject: [PATCH] add CI jobs for Symfony 7.3 --- .github/workflows/ci.yaml | 9 +++++++++ tests/Fixtures/DependencyInjection/Kernel.php | 12 ++++++++++-- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 6e69a20..4fc44e7 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -69,6 +69,9 @@ jobs: - php-version: '8.2' composer-options: '--prefer-stable' symfony-version: '7.2.*' + - php-version: '8.2' + composer-options: '--prefer-stable' + symfony-version: '7.3.*' - php-version: '8.3' composer-options: '--prefer-stable' symfony-version: '6.4.*' @@ -78,6 +81,9 @@ jobs: - php-version: '8.3' composer-options: '--prefer-stable' symfony-version: '7.2.*' + - php-version: '8.3' + composer-options: '--prefer-stable' + symfony-version: '7.3.*' - php-version: '8.4' composer-options: '--prefer-stable' symfony-version: '6.4.*' @@ -87,6 +93,9 @@ jobs: - php-version: '8.4' composer-options: '--prefer-stable' symfony-version: '7.2.*' + - php-version: '8.4' + composer-options: '--prefer-stable' + symfony-version: '7.3.*' steps: - name: 'Check out' diff --git a/tests/Fixtures/DependencyInjection/Kernel.php b/tests/Fixtures/DependencyInjection/Kernel.php index 9d82dba..d2699b5 100644 --- a/tests/Fixtures/DependencyInjection/Kernel.php +++ b/tests/Fixtures/DependencyInjection/Kernel.php @@ -16,6 +16,7 @@ namespace Qossmic\RichModelForms\Tests\Fixtures\DependencyInjection; use Qossmic\RichModelForms\RichModelFormsBundle; +use Symfony\Bundle\FrameworkBundle\Command\TranslationExtractCommand; use Symfony\Bundle\FrameworkBundle\FrameworkBundle; use Symfony\Component\Config\Loader\LoaderInterface; use Symfony\Component\DependencyInjection\Compiler\PassConfig; @@ -37,13 +38,20 @@ public function registerContainerConfiguration(LoaderInterface $loader): void $loader->load(function (ContainerBuilder $container): void { $container->addCompilerPass(new PublicTestAliasPass(), PassConfig::TYPE_BEFORE_OPTIMIZATION, 1000); $container->setParameter('kernel.secret', __FILE__); - $container->loadFromExtension('framework', [ + + $frameworkConfig = [ 'handle_all_throwables' => false, 'http_method_override' => false, 'php_errors' => [ 'log' => false, ], - ]); + ]; + + if (class_exists(TranslationExtractCommand::class)) { + $frameworkConfig['property_info']['with_constructor_extractor'] = true; + } + + $container->loadFromExtension('framework', $frameworkConfig); }); }