fix: rename translator parameters and set defaults

Author: lucargir

dagster_sqlmesh/asset.py

@@ -23,7 +23,7 @@ def sqlmesh_assets(
     config: SQLMeshContextConfig,
     context_factory: ContextFactory[ContextCls] = lambda **kwargs: Context(**kwargs),
     name: str | None = None,
-    dagster_sqlmesh_translator: SQLMeshDagsterTranslator | None = None,
+    dagster_sqlmesh_translator: SQLMeshDagsterTranslator = SQLMeshDagsterTranslator(),
     compute_kind: str = "sqlmesh",
     op_tags: t.Mapping[str, t.Any] | None = None,
     required_resource_keys: set[str] | None = None,
@@ -32,8 +32,6 @@ def sqlmesh_assets(
     enabled_subsetting: bool = False,
 ) -> t.Callable[[t.Callable[..., t.Any]], AssetsDefinition]:
     controller = DagsterSQLMeshController.setup_with_config(config=config, context_factory=context_factory)
-    if not dagster_sqlmesh_translator:
-        dagster_sqlmesh_translator = dagster_sqlmesh_translator
 
     conversion = controller.to_asset_outs(environment, translator=dagster_sqlmesh_translator)
 

dagster_sqlmesh/controller/base.py

@@ -427,12 +427,12 @@ def setup(
         context_factory: ContextFactory[ContextCls],
         gateway: str = "local",
         log_override: logging.Logger | None = None,
-        translator_override: SQLMeshDagsterTranslator | None = None,
+        translator: SQLMeshDagsterTranslator = SQLMeshDagsterTranslator(),
     ) -> t.Self:
         return cls.setup_with_config(
             config=SQLMeshContextConfig(path=path, gateway=gateway),
             log_override=log_override,
-            translator_override=translator_override,
+            translator=translator,
             context_factory=context_factory,
         )
 
@@ -443,15 +443,15 @@ def setup_with_config(
         config: SQLMeshContextConfig,
         context_factory: ContextFactory[ContextCls] = DEFAULT_CONTEXT_FACTORY,
         log_override: logging.Logger | None = None,
-        translator_override: SQLMeshDagsterTranslator | None = None,
+        translator: SQLMeshDagsterTranslator = SQLMeshDagsterTranslator(),
     ) -> t.Self:
         console = EventConsole(log_override=log_override) # type: ignore
         controller = cls(
             console=console,
             config=config,
             log_override=log_override,
             context_factory=context_factory,
-            translator_override=translator_override
+            translator=translator
         )
         return controller
 
@@ -461,13 +461,13 @@ def __init__(
         console: EventConsole,
         context_factory: ContextFactory[ContextCls],
         log_override: logging.Logger | None = None,
-        translator_override: SQLMeshDagsterTranslator | None = None,
+        translator: SQLMeshDagsterTranslator = SQLMeshDagsterTranslator(),
     ) -> None:
         self.config = config
         self.console = console
         self.logger = log_override or logger
         self._context_factory = context_factory
-        self.translator = translator_override or SQLMeshDagsterTranslator()
+        self.translator = translator
         self._context_open = False
 
     def set_logger(self, logger: logging.Logger) -> None:

dagster_sqlmesh/resource.py

@@ -417,11 +417,11 @@ def get_controller(
         self,
         context_factory: ContextFactory[ContextCls],
         log_override: logging.Logger | None = None,
-        translator: SQLMeshDagsterTranslator | None = None
+        translator: SQLMeshDagsterTranslator = SQLMeshDagsterTranslator(),
     ) -> DagsterSQLMeshController[ContextCls]:
         return DagsterSQLMeshController.setup_with_config(
             config=self.config,
             context_factory=context_factory,
             log_override=log_override,
-            translator_override=translator
+            translator=translator
         )