feat: migrate repo to eslint v9 (#5476)

* feat: upgrade `eslint` config to `flat` config

* chore: upgrade `eslint` to `v9`

* chore: update `pnpm` lockfile

* chore: migrate `apps/docs` to eslint `flat` config

* chore: migrate `apps/frontend` to eslint `flat` config

* chore: disable unnecessary `eslint-disable-*` comments

* fix: ignore auto `generated` files

* fix: remove `deprecated` lint option

* chore: migrate `apps/hasura-clickhouse` to eslint `flat` config

* chore: migrate `apps/hasura2` to eslint `flat` config

* chore: migrate `lib/oss-artifact-validators` to eslint `flat` config

* chore: migrate `lib/utils` to eslint `flat` config

* chore: migrate `ops/external-prs` to eslint `flat` config

* chore: migrate `ops/github-app-utils` to eslint `flat` config

Author: Jabolol

.eslintrc.js

@@ -1,6 +1,6 @@
 {
     "**/!(.eslintrc)*.{js,jsx,ts,tsx,sol}": [
-        "eslint --fix --ignore-path .gitignore --max-warnings 0",
+        "eslint --fix --max-warnings 0 --no-ignore",
         "prettier --ignore-path .gitignore --write",
         "prettier --ignore-path .gitignore --log-level warn --check"
     ],

.lintstagedrc

@@ -1,17 +1,8 @@
 import path from "node:path";
-import { fileURLToPath } from "node:url";
-import js from "@eslint/js";
-import { FlatCompat } from "@eslint/eslintrc";
 import { includeIgnoreFile } from "@eslint/compat";
+import rootConfig from "../../eslint.config.mjs";
 
-const __filename = fileURLToPath(import.meta.url);
-const __dirname = path.dirname(__filename);
-const gitignorePath = path.resolve(__dirname, ".gitignore");
-const compat = new FlatCompat({
-    baseDirectory: __dirname,
-    recommendedConfig: js.configs.recommended,
-    allConfig: js.configs.all
-});
+const gitignorePath = path.resolve(new URL(".", import.meta.url).pathname, ".gitignore");
 
 export default [
     includeIgnoreFile(gitignorePath),
@@ -32,13 +23,13 @@ export default [
             "**/yarn-debug.log*",
             "**/yarn-error.log*",
         ],
-    }, ...compat.extends("../../.eslintrc.js"), {
+    }, ...rootConfig, {
         languageOptions: {
             ecmaVersion: 5,
             sourceType: "script",
 
             parserOptions: {
-                project: ["./apps/docs/tsconfig.json"],
+                project: ["./tsconfig.json"],
             },
         },
 

apps/docs/.eslintrc.json

@@ -17,7 +17,7 @@
     "write-heading-ids": "docusaurus write-heading-ids",
     "lint": "pnpm lint:eslint && pnpm lint:prettier",
     "lint:eslint": "eslint --max-warnings 0 .",
-    "lint:prettier": "prettier --ignore-path ../../.gitignore --ignore-path .gitignore --ignore-path .prettierignore --log-level warn --check **/*.{js,jsx,ts,tsx,sol,md,json}",
+    "lint:prettier": "prettier --ignore-path ../../.gitignore --ignore-path .gitignore --ignore-path .prettierignore --log-level warn --check **/*.{js,ts,tsx,md,json}",
     "plasmic:update": "pnpm update @plasmicapp/cli @plasmicapp/react-web",
     "plasmic:sync": "pnpm plasmic sync --yes --force",
     "update:deps": "ncu -i"

apps/docs/eslint.config.mjs

@@ -127,7 +127,6 @@ const DEFAULT_MENU_ITEMS: NavBarItem[] = [
   },
 ];
 
-// eslint-disable-next-line @typescript-eslint/no-empty-object-type
 type OsoNavbarProps = {
   className?: string; // Plasmic CSS class
   menuItems?: NavBarItem[]; // Override default menu items

apps/docs/package.json

@@ -0,0 +1,73 @@
+import { defineConfig } from "eslint/config";
+import { includeIgnoreFile } from "@eslint/compat";
+import noRelativeImportPaths from "eslint-plugin-no-relative-import-paths";
+import tsParser from "@typescript-eslint/parser";
+import path from "node:path";
+import { fileURLToPath } from "node:url";
+import js from "@eslint/js";
+import { FlatCompat } from "@eslint/eslintrc";
+import { fixupConfigRules } from "@eslint/compat";
+import rootConfig from "../../eslint.config.mjs";
+import { resolveFlatConfig } from "@leancodepl/resolve-eslint-flat-config";
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+const gitignorePath = fileURLToPath(new URL(".gitignore", import.meta.url));
+const compat = new FlatCompat({
+    baseDirectory: __dirname,
+    recommendedConfig: js.configs.recommended,
+    allConfig: js.configs.all,
+});
+
+export default defineConfig(resolveFlatConfig([
+    ...rootConfig,
+    includeIgnoreFile(gitignorePath),
+    {
+        ignores: ["lib/graphql/generated/**"],
+    },
+    ...fixupConfigRules(compat.extends(
+        "next/core-web-vitals",
+        "plugin:storybook/recommended",
+    )),
+    {
+        files: ["*.mjs", "*.js"],
+        rules: {
+            "@typescript-eslint/no-misused-promises": "off",
+            "@typescript-eslint/no-floating-promises": "off",
+        },
+    },
+    {
+        files: ["**/*.{ts,tsx}"],
+
+        plugins: {
+            "no-relative-import-paths": noRelativeImportPaths,
+        },
+
+        languageOptions: {
+            parser: tsParser,
+            ecmaVersion: "latest",
+            sourceType: "module",
+
+            parserOptions: {
+                project: true,
+                projectService: {
+                    allowDefaultProject: ["*.mjs"],
+                },
+            },
+        },
+
+        rules: {
+            "react-hooks/exhaustive-deps": "off",
+
+            "no-restricted-syntax": ["error", {
+                selector: "Property[key.name='preview'][value.value=true]",
+                message: "Make sure to turn 'preview' off before committing.",
+            }],
+
+            "no-relative-import-paths/no-relative-import-paths": ["error", {
+                rootDir: ".",
+                prefix: "@",
+            }],
+        },
+    },
+]));

apps/frontend/components/widgets/oso-navbar.tsx

@@ -107,7 +107,6 @@ async function putObject(loc: ObjectLocation, body: ReadableStream) {
     partNumber++;
   };
 
-  // eslint-disable-next-line no-constant-condition
   while (true) {
     const { done, value } = await reader.read();
 

apps/frontend/eslint.config.mjs

@@ -13,9 +13,9 @@
     "dev": "pnpm codegen && next dev",
     "graphql:codegen": "dotenv -e .env.local -- graphql-codegen --require tsconfig-paths/register --config ./lib/graphql/codegen.ts && prettier --write ./lib/graphql/codegen.ts",
     "graphql:rover": "rover supergraph compose --elv2-license 'accept' --config ./supergraph-config.yaml > ./app/api/v1/graphql/supergraph.graphql",
-    "lint": "tsc --noEmit && next lint && pnpm lint:eslint && pnpm lint:prettier",
-    "lint:eslint": "eslint --ignore-path ../../.gitignore --ignore-path .gitignore --max-warnings 0 . --fix",
-    "lint:prettier": "prettier --ignore-path ../../.gitignore --ignore-path .gitignore --log-level warn --check **/*.{js,jsx,ts,tsx,sol,md,json}",
+    "lint": "tsc --noEmit && pnpm lint:eslint && pnpm lint:prettier",
+    "lint:eslint": "eslint --max-warnings 0 . --fix",
+    "lint:prettier": "prettier --ignore-path ../../.gitignore --ignore-path .gitignore --log-level warn --check **/*.{js,ts,tsx,md,json}",
     "start": "next start",
     "start-debug": "NODE_OPTIONS='--inspect' next dev",
     "supabase:codegen": "pnpm supabase:gentypes && pnpm supabase:zod",
@@ -125,9 +125,12 @@
   "devDependencies": {
     "@apollo/rover": "^0.35.0",
     "@chromatic-com/storybook": "^4.1.0",
+    "@eslint/eslintrc": "^3.3.1",
+    "@eslint/js": "^9.38.0",
     "@graphql-codegen/cli": "^5.0.7",
     "@graphql-codegen/client-preset": "^4.8.3",
     "@graphql-typed-document-node/core": "^3.2.0",
+    "@leancodepl/resolve-eslint-flat-config": "^9.6.5",
     "@parcel/watcher": "^2.5.1",
     "@storybook/addon-a11y": "^9.1.2",
     "@storybook/addon-docs": "^9.1.2",