topotests: bgp_vrf_route_leak_basic check vrf list

Check BGP VRF list in bgp_vrf_route_leak_basic.

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>

Author: louis-6wind

tests/topotests/bgp_vrf_route_leak_basic/r1/bgpd.conf

@@ -17,13 +17,6 @@ router bgp 65500 vrf EVA
     import vrf ZITA
   !
 !
-router bgp 65500 vrf ZITA
-  no bgp ebgp-requires-policy
-  no bgp network import-check
-  address-family ipv4 unicast
-    network 172.16.101.0/24
-  !
-!
 router bgp 65500
   bgp router-id 192.0.2.1
   no bgp ebgp-requires-policy

tests/topotests/bgp_vrf_route_leak_basic/test_bgp-vrf-route-leak-basic.py

@@ -79,6 +79,36 @@ def test_router_bgp_as_pretty():
     assert "router bgp 65500\n" in output, "router bgp 65500 not found in show run"
 
 
+def test_vrf_bgp_list():
+    logger.info("Ensure that BGP list does not include non existing VRFs")
+    tgen = get_topogen()
+    # Don't run this test if we have any failure.
+    if tgen.routers_have_failure():
+        pytest.skip(tgen.errors)
+
+    r1 = tgen.gears["r1"]
+
+    # Configure a VRF that is not going to be used
+    r1.cmd("ip link add MARIA type vrf table 1009")
+
+    # Attempt to remove ANNA VRF that is not present
+    r1.vtysh_cmd(
+        """
+configure
+
+router bgp 99 vrf DONNA
+  address-family ipv4 unicast
+    no import vrf ANNA
+"""
+    )
+
+    expect = {"vrfs": {"DONNA": {}, "default": {}, "EVA": {}}, "totalVrfs": 3}
+
+    test_func = partial(topotest.router_json_cmp, r1, "show bgp vrfs json", expect)
+    result, diff = topotest.run_and_expect(test_func, None, count=15, wait=1)
+    assert result, "BGP VRF list check failed:\n{}".format(diff)
+
+
 def test_vrf_route_leak_donna():
     logger.info("Ensure that routes are leaked back and forth")
     tgen = get_topogen()
@@ -382,6 +412,18 @@ def test_vrf_route_leak_donna_add_vrf_zita():
     r1 = tgen.gears["r1"]
     r1.cmd("ip link add ZITA type vrf table 1003")
 
+    r1.vtysh_cmd(
+        """
+configure
+
+router bgp 65500 vrf ZITA
+  no bgp ebgp-requires-policy
+  no bgp network import-check
+  address-family ipv4 unicast
+    network 172.16.101.0/24
+"""
+    )
+
     # Test DONNA VRF.
     expect = {
         "172.16.101.0/24": None,
@@ -393,6 +435,15 @@ def test_vrf_route_leak_donna_add_vrf_zita():
     result, diff = topotest.run_and_expect(test_func, None, count=15, wait=1)
     assert result, "BGP VRF DONNA check failed:\n{}".format(diff)
 
+    expect = {
+        "vrfs": {"DONNA": {}, "default": {}, "EVA": {}, "ZITA": {}},
+        "totalVrfs": 4,
+    }
+
+    test_func = partial(topotest.router_json_cmp, r1, "show bgp vrfs json", expect)
+    result, diff = topotest.run_and_expect(test_func, None, count=15, wait=1)
+    assert result, "BGP VRF list check failed:\n{}".format(diff)
+
 
 def test_vrf_route_leak_donna_set_zita_up():
     logger.info("Set VRF ZITA up and ensure that the route from VRF ZITA is updated")