Fix errors in QuestionnaireActivityTest

com.google.android.gms.common.api.ApiException: 17: API: LocationServices.API is not available on this device. Connection failed with: ConnectionResult{statusCode=SERVICE_INVALID, resolution=null, message=null}

Author: LZRS

.github/workflows/ci.yml

@@ -273,9 +273,7 @@ jobs:
           force-avd-creation: true
           emulator-options: -no-snapshot-save -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none
           disable-animations: true
-#          script: ./gradlew clean  -PlocalPropertiesFile=local.properties :quest:fhircoreJacocoReport --stacktrace -Pandroid.testInstrumentationRunnerArguments.notPackage=org.smartregister.fhircore.quest.performance
-#          script: ./gradlew clean  -PlocalPropertiesFile=local.properties :quest:testOpensrpDebugUnitTest --stacktrace -Pandroid.testInstrumentationRunnerArguments.notPackage=org.smartregister.fhircore.quest.performance
-          script: ./gradlew clean  -PlocalPropertiesFile=local.properties :quest:connectedOpensrpDebugAndroidTest --stacktrace -Pandroid.testInstrumentationRunnerArguments.notPackage=org.smartregister.fhircore.quest.performance
+          script: ./gradlew clean  -PlocalPropertiesFile=local.properties :quest:fhircoreJacocoReport --stacktrace -Pandroid.testInstrumentationRunnerArguments.notPackage=org.smartregister.fhircore.quest.performance
 
       - name: Run Quest module unit and instrumentation tests and generate aggregated coverage report (Disabled)
         if: false

android/quest/src/main/assets/configs/app/application_config.json

@@ -83,8 +83,6 @@
       ]
     }
   ],
-  "logGpsLocation": [
-    "QUESTIONNAIRE"
-  ],
+  "logGpsLocation": [],
   "dateFormat": "MMM d, hh:mm aa"
 }

android/quest/src/main/java/org/smartregister/fhircore/quest/ui/questionnaire/QuestionnaireActivity.kt

@@ -35,7 +35,6 @@ import androidx.core.os.bundleOf
 import androidx.fragment.app.commit
 import androidx.lifecycle.lifecycleScope
 import com.google.android.fhir.datacapture.QuestionnaireFragment
-import com.google.android.gms.location.FusedLocationProviderClient
 import com.google.android.gms.location.LocationServices
 import dagger.hilt.android.AndroidEntryPoint
 import java.io.Serializable
@@ -78,7 +77,6 @@ class QuestionnaireActivity : BaseMultiLanguageActivity() {
   private lateinit var viewBinding: QuestionnaireActivityBinding
   private var questionnaire: Questionnaire? = null
   private var alertDialog: AlertDialog? = null
-  private lateinit var fusedLocationClient: FusedLocationProviderClient
   private var currentLocation: Location? = null
   private val locationPermissionLauncher: ActivityResultLauncher<Array<String>> =
     registerForActivityResult(ActivityResultContracts.RequestMultiplePermissions()) {
@@ -155,8 +153,6 @@ class QuestionnaireActivity : BaseMultiLanguageActivity() {
     if (
       viewModel.applicationConfiguration.logGpsLocation.contains(LocationLogOptions.QUESTIONNAIRE)
     ) {
-      fusedLocationClient = LocationServices.getFusedLocationProviderClient(this)
-
       if (!LocationUtils.isLocationEnabled(this)) {
         showLocationSettingsDialog(
           Intent(Settings.ACTION_LOCATION_SOURCE_SETTINGS).apply {
@@ -195,6 +191,9 @@ class QuestionnaireActivity : BaseMultiLanguageActivity() {
   }
 
   fun fetchLocation(highAccuracy: Boolean = true) {
+    val fusedLocationClient =
+      LocationServices.getFusedLocationProviderClient(this@QuestionnaireActivity)
+
     lifecycleScope.launch {
       try {
         currentLocation =

android/quest/src/test/assets/configs/app/application_config.json

@@ -77,7 +77,5 @@
       }
     }
   ],
-  "logGpsLocation": [
-    "QUESTIONNAIRE"
-  ]
+  "logGpsLocation": []
 }

android/quest/src/test/java/org/smartregister/fhircore/quest/ui/questionnaire/QuestionnaireActivityTest.kt

@@ -25,7 +25,6 @@ import android.widget.Toast
 import androidx.test.core.app.ApplicationProvider
 import com.google.android.fhir.FhirEngine
 import com.google.android.fhir.db.ResourceNotFoundException
-import com.google.android.gms.location.LocationServices
 import dagger.hilt.android.testing.BindValue
 import dagger.hilt.android.testing.HiltAndroidRule
 import dagger.hilt.android.testing.HiltAndroidTest
@@ -57,8 +56,10 @@ import org.robolectric.Shadows.shadowOf
 import org.robolectric.android.controller.ActivityController
 import org.robolectric.shadows.ShadowAlertDialog
 import org.robolectric.shadows.ShadowToast
+import org.smartregister.fhircore.engine.configuration.ConfigType
 import org.smartregister.fhircore.engine.configuration.ConfigurationRegistry
 import org.smartregister.fhircore.engine.configuration.QuestionnaireConfig
+import org.smartregister.fhircore.engine.configuration.app.ApplicationConfiguration
 import org.smartregister.fhircore.engine.configuration.app.LocationLogOptions
 import org.smartregister.fhircore.engine.data.local.ContentCache
 import org.smartregister.fhircore.engine.data.local.DefaultRepository
@@ -205,29 +206,29 @@ class QuestionnaireActivityTest : RobolectricTest() {
   fun `setupLocationServices should open location settings if location is disabled`() = runTest {
     // Questionnaire will be retrieved from the database
     fhirEngine.create(questionnaire.apply { id = questionnaireConfig.id })
+    val initialConfig =
+      configurationRegistry.retrieveConfiguration<ApplicationConfiguration>(ConfigType.Application)
+    val logQuestionnaireGpsConfig =
+      initialConfig.copy(logGpsLocation = listOf(LocationLogOptions.QUESTIONNAIRE))
+    configurationRegistry.configCacheMap[ConfigType.Application.name] = logQuestionnaireGpsConfig
+
+    shadowOf(context).grantPermissions(android.Manifest.permission.ACCESS_FINE_LOCATION)
+    val locationManager = context.getSystemService(Context.LOCATION_SERVICE) as LocationManager
+    locationManager.setTestProviderEnabled(LocationManager.GPS_PROVIDER, false)
+    locationManager.setTestProviderEnabled(LocationManager.NETWORK_PROVIDER, false)
+
     setupActivity()
     assertTrue(
       questionnaireActivity.viewModel.applicationConfiguration.logGpsLocation.contains(
         LocationLogOptions.QUESTIONNAIRE,
       ),
     )
-
-    val fusedLocationProviderClient =
-      LocationServices.getFusedLocationProviderClient(questionnaireActivity)
-    assertNotNull(fusedLocationProviderClient)
-
-    shadowOf(questionnaireActivity)
-      .grantPermissions(android.Manifest.permission.ACCESS_FINE_LOCATION)
-    val locationManager =
-      questionnaireActivity.getSystemService(Context.LOCATION_SERVICE) as LocationManager
-    locationManager.setTestProviderEnabled(LocationManager.GPS_PROVIDER, false)
-    locationManager.setTestProviderEnabled(LocationManager.NETWORK_PROVIDER, false)
-
-    questionnaireActivity.fetchLocation()
     val startedIntent = shadowOf(questionnaireActivity).nextStartedActivity
     val expectedIntent = Intent(Settings.ACTION_LOCATION_SOURCE_SETTINGS)
 
     assertEquals(expectedIntent.component, startedIntent.component)
+    // reset
+    configurationRegistry.configCacheMap[ConfigType.Application.name] = initialConfig
   }
 
   @Test