Skip to content

Commit ef9eaae

Browse files
committed
Pin websockets library (#669)
* Pin websockets library Set upper bound for websockets until libjuju is compatible with newer versions. See juju/python-libjuju#1208 * Migrate to actions/upload-artifact@v4 (cherry picked from commit d758d6d)
1 parent 6787575 commit ef9eaae

File tree

4 files changed

+12
-1
lines changed

4 files changed

+12
-1
lines changed

.github/workflows/tox.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ jobs:
110110
juju-crashdump -m $model -o logs/
111111
- name: upload logs on failure
112112
if: failure()
113-
uses: actions/upload-artifact@v2
113+
uses: actions/upload-artifact@v4
114114
with:
115115
name: test-run-logs-and-crashdump
116116
path: logs/

requirements.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,3 +35,7 @@ sphinx
3535
sphinxcontrib-asyncio
3636
# https://github.com/go-macaroon-bakery/py-macaroon-bakery/issues/94
3737
macaroonbakery!=1.3.3
38+
39+
# NOTE(freyes): Set upper bound for websockets until libjuju is compatible with
40+
# newer versions. See https://github.com/juju/python-libjuju/pull/1208
41+
websockets<13.0.0

setup.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,9 @@
4343

4444
# https://github.com/go-macaroon-bakery/py-macaroon-bakery/issues/94
4545
'macaroonbakery != 1.3.3',
46+
# NOTE(freyes): Set upper bound for websockets until libjuju is compatible
47+
# with newer versions. See https://github.com/juju/python-libjuju/pull/1208
48+
'websockets<13.0.0',
4649
]
4750
if os.environ.get("TEST_JUJU3"):
4851
install_require.append('juju')

test-requirements.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@ keystoneauth1
1616
oslo.config
1717
python-novaclient
1818
tenacity>8.2.0
19+
# NOTE(freyes): Set upper bound for websockets until libjuju is compatible with
20+
# newer versions. See https://github.com/juju/python-libjuju/pull/1208
21+
websockets<13.0.0
22+
1923
# To force the installation of an specific version of libjuju use a constraints
2024
# file, e.g.: `env PIP_CONSTRAINTS=./constraints-juju31.txt tox -e func-target`
2125
juju

0 commit comments

Comments
 (0)