Merge pull request #686 from bogdando/nova02beta

nova02: Fix install nvidia driver w/o trusted  crt and casting pci address as a string

Fix install nvidia driver w/o trusted crt
For http:// or https:// URLs:


Download the RPM with get_url and validate_certs: false to /tmp/.rpm on the target host.
Set nvidia_rpm_install_path to that local path for HTTP(S), or to the original value for file:// or local paths.
Install with dnf using nvidia_rpm_install_path (local file or path), so no HTTPS is done by dnf.

NOTE: eventually, we should switch to edpm accel driver role, but it needs to be shipped with rhoso to be consumed directly here


do not convert from YAML nvidia_pci_address
...because it will be translated into wrong (datatime) value.

Reviewed-by: Andrew Bays <andrew.bays@gmail.com>

Author: softwarefactory-project-zuul[bot]

dt/nova/nova02beta/edpm/nodeset/nova_sriov.yaml

@@ -77,10 +77,24 @@ spec:
         - name: Gather the package facts
           ansible.builtin.package_facts:
             manager: auto
+        - name: Download NVIDIA driver RPM from URL (skip SSL verify for internal servers)
+          become: true
+          ansible.builtin.get_url:
+            url: "{{ nvidia_rpm_url }}"
+            dest: "/tmp/{{ nvidia_rpm_url.split('/')[-1] }}"
+            validate_certs: false
+          when:
+            - nvidia_rpm_url not in ansible_facts.packages
+            - nvidia_rpm_url is match('^https?://')
+          register: _nvidia_rpm_download
+        - name: Set NVIDIA RPM install path (local file after download or original URL/path)
+          ansible.builtin.set_fact:
+            nvidia_rpm_install_path: "{{ ('/tmp/' + nvidia_rpm_url.split('/')[-1]) if nvidia_rpm_url is match('^https?://') else nvidia_rpm_url }}"
+          when: nvidia_rpm_url not in ansible_facts.packages
         - name: Install nvidia driver RPM either from path or URL
           become: true
           ansible.builtin.dnf:
-            name: "{{ nvidia_rpm_url }}"
+            name: "{{ nvidia_rpm_install_path }}"
             state: present
             disable_gpg_check: true
           when: nvidia_rpm_url not in ansible_facts.packages

dt/nova/nova02beta/edpm/nodeset2/nova_sriov.yaml

@@ -113,20 +113,36 @@ spec:
             - "/tmp/nvidia-sriov.pp"
           when: policy_file.changed
 
-        - name: Get the Nvidia Driver URL
+        - name: Load NVIDIA config from controller mount
           delegate_to: localhost
           ansible.builtin.set_fact:
-            nvidia_rpm_url: "{{ lookup('file', '/var/lib/openstack/configs/install-nvidia-sriov/nvidia_driver_url') | from_yaml }}"
-            nvidia_pci_address: "{{ lookup('file', '/var/lib/openstack/configs/install-nvidia-sriov/nvidia_pci_address') | from_yaml }}"
+            nvidia_rpm_url: "{{ lookup('file', '/var/lib/openstack/configs/install-nvidia-sriov/nvidia_driver_url') | from_yaml | trim }}"
+            nvidia_pci_address: "{{ lookup('file', '/var/lib/openstack/configs/install-nvidia-sriov/nvidia_pci_address') | trim }}"
 
         - name: Gather the package facts
           ansible.builtin.package_facts:
             manager: auto
 
+        - name: Download NVIDIA driver RPM from URL (skip SSL verify for internal servers)
+          become: true
+          ansible.builtin.get_url:
+            url: "{{ nvidia_rpm_url }}"
+            dest: "/tmp/{{ nvidia_rpm_url.split('/')[-1] }}"
+            validate_certs: false
+          when:
+            - nvidia_rpm_url not in ansible_facts.packages
+            - nvidia_rpm_url is match('^https?://')
+          register: _nvidia_rpm_download
+
+        - name: Set NVIDIA RPM install path (local file after download or original URL/path)
+          ansible.builtin.set_fact:
+            nvidia_rpm_install_path: "{{ ('/tmp/' + nvidia_rpm_url.split('/')[-1]) if nvidia_rpm_url is match('^https?://') else nvidia_rpm_url }}"
+          when: nvidia_rpm_url not in ansible_facts.packages
+
         - name: Install nvidia driver RPM either from path or URL
           become: true
           ansible.builtin.dnf:
-            name: "{{ nvidia_rpm_url }}"
+            name: "{{ nvidia_rpm_install_path }}"
             state: present
             disable_gpg_check: true
           when: nvidia_rpm_url not in ansible_facts.packages