Skip to content

Commit abfd05b

Browse files
committed
squashme: minor fixes after the AI agent work
Signed-off-by: Bohdan Dobrelia <[email protected]>
1 parent 9d9f515 commit abfd05b

File tree

11 files changed

+25
-5
lines changed

11 files changed

+25
-5
lines changed

dt/nova/nova04delta/edpm/nodeset/kustomization.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ replacements:
3838
options:
3939
create: true
4040

41-
# Nova compute PCI passthrough customization
41+
# Nova compute CPU pinning customization
4242
- source:
4343
kind: ConfigMap
4444
name: edpm-nodeset-values
@@ -51,6 +51,7 @@ replacements:
5151
- data.25-cpu-pinning-nova\.conf
5252
options:
5353
create: true
54+
# Nova compute PCI passthrough customization
5455
- source:
5556
kind: ConfigMap
5657
name: edpm-nodeset-values

dt/nova/nova04delta/edpm/nodeset/nova_gpu.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
---
12
apiVersion: v1
23
kind: ConfigMap
34
metadata:

dt/nova/nova04delta/edpm/nodeset2/kustomization.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ replacements:
3838
options:
3939
create: true
4040

41-
# Nova compute PCI passthrough customization
41+
# Nova compute CPU pinning customization
4242
- source:
4343
kind: ConfigMap
4444
name: edpm-nodeset-values
@@ -51,6 +51,7 @@ replacements:
5151
- data.25-cpu-pinning-nova\.conf
5252
options:
5353
create: true
54+
# Nova compute PCI passthrough customization
5455
- source:
5556
kind: ConfigMap
5657
name: edpm-nodeset-values

dt/nova/nova04delta/edpm/nodeset2/nova_gpu.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
---
12
apiVersion: v1
23
kind: ConfigMap
34
metadata:

examples/dt/nova/nova04delta/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ The following parameters are crucial for host-level configuration:
2929

3030
## Nova Configuration
3131

32+
# FIXME: this looks only used in PCI groups in placement? The same pci_passthrough:alias should be used in both cases it seems?
3233
Nova control plane is configured for requesting PCI devices from Placement
3334
through `resources:VGPU=X` flavor extra specs.
3435
That is a contrary to the legacy mode where PCI devices used to be requested through

examples/va/nvidia-vfio-passthrough/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ with nested virtualization and requires real baremetal hosts.
1616

1717
### Nova
1818

19+
# FIXME: this looks only used in PCI groups in placement? The same pci_passthrough:alias should be used in both cases it seems?
1920
Nova control plane is configured for requesting PCI devices from Placement
2021
by setting `resources:VGPU=X` in flavor extra specs.
2122
That is a contrary to the legacy mode where PCI devices used to be requested through

examples/va/nvidia-vfio-passthrough/control-plane/kustomization.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ replacements:
4040
- spec.neutron.template.customServiceConfig
4141
options:
4242
create: true
43-
# OVN control plane SRIOV customization
43+
# OVN control plane customization
4444
- source:
4545
kind: ConfigMap
4646
name: service-values

examples/va/nvidia-vfio-passthrough/edpm/nodeset/kustomization.yaml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,18 @@ replacements:
4848
- spec.baremetalSetTemplate
4949
options:
5050
create: true
51+
- source:
52+
kind: ConfigMap
53+
name: edpm-nodeset-values
54+
fieldPath: data.nova.compute.conf
55+
targets:
56+
- select:
57+
kind: ConfigMap
58+
name: cpu-pinning-nova
59+
fieldPaths:
60+
- data.25-cpu-pinning-nova\.conf
61+
options:
62+
create: true
5163
- source:
5264
kind: ConfigMap
5365
name: edpm-nodeset-values

va/nvidia-vfio-passthrough/edpm/nodeset/kustomization.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ replacements:
3838
options:
3939
create: true
4040

41-
# Nova compute PCI passthrough customization
41+
# Nova compute CPU pinning customization
4242
- source:
4343
kind: ConfigMap
4444
name: edpm-nodeset-values
@@ -51,6 +51,7 @@ replacements:
5151
- data.25-cpu-pinning-nova\.conf
5252
options:
5353
create: true
54+
# Nova compute PCI passthrough customization
5455
- source:
5556
kind: ConfigMap
5657
name: edpm-nodeset-values

va/nvidia-vfio-passthrough/edpm/nodeset/nova_gpu.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
---
12
apiVersion: v1
23
kind: ConfigMap
34
metadata:

0 commit comments

Comments
 (0)