Skip to content

Enable octavia in uni02beta #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Enable octavia in uni02beta #536

wants to merge 1 commit into from
+363 −3

Conversation

@lavraham
Copy link
Contributor

@lavraham lavraham commented Apr 8, 2025 •
edited
Loading

We want to run the Octavia Tobiko workflow in the uni02beta job. Octavia is disabled by default in the control plane, and we need to enable Octavia to run Tobiko tests.

JIRA Ticket - https://issues.redhat.com/browse/OSPRH-17906

@openshift-ci openshift-ci bot requested review from abays and cjeanner April 8, 2025 10:58
@openshift-ci
Copy link

openshift-ci bot commented Apr 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lavraham
Once this PR has been reviewed and has the lgtm label, please assign raukadah for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lavraham lavraham marked this pull request as draft April 8, 2025 10:58
@lavraham lavraham force-pushed the enable_octavia_uni02beta branch from b737656 to e53c15e Compare April 9, 2025 07:30
@lavraham lavraham force-pushed the enable_octavia_uni02beta branch from e53c15e to 2134888 Compare April 21, 2025 06:02
@lavraham lavraham force-pushed the enable_octavia_uni02beta branch 3 times, most recently from f2dc31b to e0fe5cc Compare June 11, 2025 17:54
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Jun 11, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2df55993f7ed4607b1a9460efd0df13f

✔️ noop SUCCESS in 0s
❌ rhoso-architecture-validate-uni02beta FAILURE in 4m 39s

@lavraham lavraham force-pushed the enable_octavia_uni02beta branch from e0fe5cc to c7d8748 Compare June 11, 2025 18:02
@lavraham lavraham force-pushed the enable_octavia_uni02beta branch from c7d8748 to 464389f Compare July 1, 2025 06:51
@lavraham lavraham force-pushed the enable_octavia_uni02beta branch from 464389f to ea9187c Compare July 9, 2025 15:03
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Jul 9, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c8ac51d4182c4be08e2f1c4b86c06346

✔️ noop SUCCESS in 0s
❌ rhoso-architecture-validate-uni02beta FAILURE in 4m 11s

@lavraham lavraham force-pushed the enable_octavia_uni02beta branch 3 times, most recently from ba4395b to 130e64f Compare July 10, 2025 11:06
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Jul 10, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/dbb3d891715b47168379516687f6ef19

✔️ noop SUCCESS in 0s
❌ rhoso-architecture-validate-uni02beta FAILURE in 3m 17s
❌ rhoso-architecture-validate-uni02beta-adoption FAILURE in 4m 16s

@lavraham lavraham force-pushed the enable_octavia_uni02beta branch 2 times, most recently from 0d89ef6 to 8ded903 Compare July 10, 2025 11:47
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Jul 10, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2a02a365329249428acea151aef44f51

✔️ noop SUCCESS in 0s
❌ rhoso-architecture-validate-uni02beta FAILURE in 3m 11s
❌ rhoso-architecture-validate-uni02beta-adoption FAILURE in 4m 38s

@lavraham lavraham force-pushed the enable_octavia_uni02beta branch from 8ded903 to 5282796 Compare July 10, 2025 12:27
@lavraham lavraham force-pushed the enable_octavia_uni02beta branch from 5282796 to 0a67efb Compare September 28, 2025 13:09
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Sep 28, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8c6e18f3cdc94379b188ec7676ba4739

✔️ noop SUCCESS in 0s
❌ rhoso-architecture-validate-uni02beta POST_FAILURE in 3m 36s
❌ rhoso-architecture-validate-uni02beta-adoption POST_FAILURE in 4m 13s

@lavraham lavraham force-pushed the enable_octavia_uni02beta branch from 0a67efb to e11d4f8 Compare October 22, 2025 10:43
@lavraham lavraham marked this pull request as ready for review October 22, 2025 10:44
@openshift-ci openshift-ci bot requested review from karelyatin and raukadah October 22, 2025 10:44
@lavraham lavraham requested a review from beagles October 22, 2025 10:44
@lavraham lavraham added the ready-review Request is ready to be reviewed label Oct 23, 2025
abays
abays reviewed Nov 3, 2025
View reviewed changes
examples/dt/uni02beta/control-plane/service-values.yaml

octavia:
enabled: true
amphoraImageContainerImage: quay.io/gthiemonge/octavia-amphora-image
Copy link
Contributor

@abays abays Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it intentional to use someone's personal Quay image here?

Copy link
Contributor

@gthiemonge gthiemonge Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it's intentional,
unfortunately, there's no official upstream image for the amphora (but there's a plan to have one) , so we keep this image to have at least a functional/working environment.
amphoraImageContainerImage is overridden by ci-framework in the downstream jobs with the amphora image from RHOSO

abays
abays reviewed Nov 3, 2025
View reviewed changes
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, but since this affects a uni job it will need CIOps approval

@lavraham lavraham marked this pull request as draft November 3, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abays abays abays left review comments

@gthiemonge gthiemonge gthiemonge left review comments

@cjeanner cjeanner Awaiting requested review from cjeanner

@karelyatin karelyatin Awaiting requested review from karelyatin

@raukadah raukadah Awaiting requested review from raukadah

@beagles beagles Awaiting requested review from beagles

Assignees

No one assigned

Labels

do-not-merge/work-in-progress ready-review Request is ready to be reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lavraham @abays @beagles @gthiemonge