Skip to content

Commit ac25c73

Browse files
Merge pull request #269 from ratailor/fix-logger
Use structured logging
2 parents 117d547 + f73fc43 commit ac25c73

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

controllers/barbican_controller.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -613,20 +613,20 @@ func (r *BarbicanReconciler) SetupWithManager(mgr ctrl.Manager) error {
613613
func (r *BarbicanReconciler) findObjectForSrc(ctx context.Context, src client.Object) []reconcile.Request {
614614
requests := []reconcile.Request{}
615615

616-
l := log.FromContext(ctx).WithName("Controllers").WithName("Barbican")
616+
Log := r.GetLogger(ctx)
617617

618618
crList := &barbicanv1beta1.BarbicanList{}
619619
listOps := &client.ListOptions{
620620
Namespace: src.GetNamespace(),
621621
}
622622
err := r.Client.List(ctx, crList, listOps)
623623
if err != nil {
624-
l.Error(err, fmt.Sprintf("listing %s for namespace: %s", crList.GroupVersionKind().Kind, src.GetNamespace()))
624+
Log.Error(err, fmt.Sprintf("listing %s for namespace: %s", crList.GroupVersionKind().Kind, src.GetNamespace()))
625625
return requests
626626
}
627627

628628
for _, item := range crList.Items {
629-
l.Info(fmt.Sprintf("input source %s changed, reconcile: %s - %s", src.GetName(), item.GetName(), item.GetNamespace()))
629+
Log.Info(fmt.Sprintf("input source %s changed, reconcile: %s - %s", src.GetName(), item.GetName(), item.GetNamespace()))
630630

631631
requests = append(requests,
632632
reconcile.Request{

controllers/barbicanapi_controller.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1014,7 +1014,7 @@ func (r *BarbicanAPIReconciler) SetupWithManager(mgr ctrl.Manager) error {
10141014
func (r *BarbicanAPIReconciler) findObjectsForSrc(ctx context.Context, src client.Object) []reconcile.Request {
10151015
requests := []reconcile.Request{}
10161016

1017-
l := log.FromContext(ctx).WithName("Controllers").WithName("BarbicanAPI")
1017+
Log := r.GetLogger(ctx)
10181018

10191019
for _, field := range apiWatchFields {
10201020
crList := &barbicanv1beta1.BarbicanAPIList{}
@@ -1024,12 +1024,12 @@ func (r *BarbicanAPIReconciler) findObjectsForSrc(ctx context.Context, src clien
10241024
}
10251025
err := r.List(ctx, crList, listOps)
10261026
if err != nil {
1027-
l.Error(err, fmt.Sprintf("listing %s for field: %s - %s", crList.GroupVersionKind().Kind, field, src.GetNamespace()))
1027+
Log.Error(err, fmt.Sprintf("listing %s for field: %s - %s", crList.GroupVersionKind().Kind, field, src.GetNamespace()))
10281028
return requests
10291029
}
10301030

10311031
for _, item := range crList.Items {
1032-
l.Info(fmt.Sprintf("input source %s changed, reconcile: %s - %s", src.GetName(), item.GetName(), item.GetNamespace()))
1032+
Log.Info(fmt.Sprintf("input source %s changed, reconcile: %s - %s", src.GetName(), item.GetName(), item.GetNamespace()))
10331033

10341034
requests = append(requests,
10351035
reconcile.Request{

controllers/barbicankeystonelistener_controller.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -724,7 +724,7 @@ func (r *BarbicanKeystoneListenerReconciler) SetupWithManager(mgr ctrl.Manager)
724724
func (r *BarbicanKeystoneListenerReconciler) findObjectsForSrc(ctx context.Context, src client.Object) []reconcile.Request {
725725
requests := []reconcile.Request{}
726726

727-
l := log.FromContext(ctx).WithName("Controllers").WithName("BarbicanKeystoneListener")
727+
Log := r.GetLogger(ctx)
728728

729729
for _, field := range listenerWatchFields {
730730
crList := &barbicanv1beta1.BarbicanKeystoneListenerList{}
@@ -734,12 +734,12 @@ func (r *BarbicanKeystoneListenerReconciler) findObjectsForSrc(ctx context.Conte
734734
}
735735
err := r.List(ctx, crList, listOps)
736736
if err != nil {
737-
l.Error(err, fmt.Sprintf("listing %s for field: %s - %s", crList.GroupVersionKind().Kind, field, src.GetNamespace()))
737+
Log.Error(err, fmt.Sprintf("listing %s for field: %s - %s", crList.GroupVersionKind().Kind, field, src.GetNamespace()))
738738
return requests
739739
}
740740

741741
for _, item := range crList.Items {
742-
l.Info(fmt.Sprintf("input source %s changed, reconcile: %s - %s", src.GetName(), item.GetName(), item.GetNamespace()))
742+
Log.Info(fmt.Sprintf("input source %s changed, reconcile: %s - %s", src.GetName(), item.GetName(), item.GetNamespace()))
743743

744744
requests = append(requests,
745745
reconcile.Request{

controllers/barbicanworker_controller.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -746,7 +746,7 @@ func (r *BarbicanWorkerReconciler) SetupWithManager(mgr ctrl.Manager) error {
746746
func (r *BarbicanWorkerReconciler) findObjectsForSrc(ctx context.Context, src client.Object) []reconcile.Request {
747747
requests := []reconcile.Request{}
748748

749-
l := log.FromContext(ctx).WithName("Controllers").WithName("BarbicanWorker")
749+
Log := r.GetLogger(ctx)
750750

751751
for _, field := range workerWatchFields {
752752
crList := &barbicanv1beta1.BarbicanWorkerList{}
@@ -756,12 +756,12 @@ func (r *BarbicanWorkerReconciler) findObjectsForSrc(ctx context.Context, src cl
756756
}
757757
err := r.List(ctx, crList, listOps)
758758
if err != nil {
759-
l.Error(err, fmt.Sprintf("listing %s for field: %s - %s", crList.GroupVersionKind().Kind, field, src.GetNamespace()))
759+
Log.Error(err, fmt.Sprintf("listing %s for field: %s - %s", crList.GroupVersionKind().Kind, field, src.GetNamespace()))
760760
return requests
761761
}
762762

763763
for _, item := range crList.Items {
764-
l.Info(fmt.Sprintf("input source %s changed, reconcile: %s - %s", src.GetName(), item.GetName(), item.GetNamespace()))
764+
Log.Info(fmt.Sprintf("input source %s changed, reconcile: %s - %s", src.GetName(), item.GetName(), item.GetNamespace()))
765765

766766
requests = append(requests,
767767
reconcile.Request{

0 commit comments

Comments
 (0)