[multiple] Move ansible_user_dir to group_vars [1/5]

This commit is one of the steps of replacing common used vars with group_vars to improve overall maintenance of variables in ci-framework

Signed-off-by: Amartya Sinha <[email protected]>

Author: amartyasinha

reproducer-clean.yml

@@ -72,7 +72,7 @@
         - deepscrub
       delegate_to: localhost
       ansible.builtin.file:
-        path: "{{ lookup('env', 'HOME') }}/ci-framework-data/ci-reproducer"
+        path: "{{ ansible_user_dir }}/ci-framework-data/ci-reproducer"
         state: absent
 
     - name: Remove basedir

roles/ci_gen_kustomize_values/molecule/default/prepare.yml

@@ -20,7 +20,7 @@
   vars:
     cifmw_ci_gen_kustomize_values_src_dir: >-
       {{
-        (lookup('env', 'HOME'),
+        (ansible_user_dir,
          'ci-framework-data',
          'artifacts', 'ci_k8s_snippets') | path_join
       }}

roles/cifmw_setup/defaults/main.yml

@@ -1,3 +1,2 @@
 ---
-ansible_user_dir: "{{ lookup('env', 'HOME') }}"
 openstack_namespace: openstack

roles/rhol_crc/molecule/add_crc_creds/converge.yml

@@ -18,7 +18,6 @@
   hosts: all
   gather_facts: true
   vars:
-    ansible_user_dir: "{{ lookup('env', 'HOME') }}"
     cifmw_path: "{{ ansible_user_dir }}/.crc/bin:{{ ansible_user_dir }}/.crc/bin/oc:{{ ansible_user_dir }}/bin:{{ ansible_env.PATH }}"
   tasks:
     - name: Verify crc creds playbook

roles/rhol_crc/molecule/binary/cleanup.yml

@@ -18,7 +18,6 @@
 - name: Prepare
   hosts: all
   vars:
-    ansible_user_dir: "{{ lookup('env', 'HOME') }}"
     cifmw_path: "{{ ansible_user_dir }}/.crc/bin:{{ ansible_user_dir }}/.crc/bin/oc:{{ ansible_user_dir }}/bin:{{ ansible_env.PATH }}"
   tasks:
     - name: Cleanup RHOL/CRC after tests

roles/rhol_crc/molecule/default/cleanup.yml

@@ -18,7 +18,6 @@
 - name: Prepare
   hosts: all
   vars:
-    ansible_user_dir: "{{ lookup('env', 'HOME') }}"
     cifmw_path: "{{ ansible_user_dir }}/.crc/bin:{{ ansible_user_dir }}/.crc/bin/oc:{{ ansible_user_dir }}/bin:{{ ansible_env.PATH }}"
   tasks:
     - name: Cleanup CRC

roles/rhol_crc/molecule/default/converge.yml

@@ -18,7 +18,6 @@
   hosts: all
   gather_facts: true
   vars:
-    ansible_user_dir: "{{ lookup('env', 'HOME') }}"
     cifmw_path: "{{ ansible_user_dir }}/.crc/bin:{{ ansible_user_dir }}/.crc/bin/oc:{{ ansible_user_dir }}/bin:{{ ansible_env.PATH }}"
     cifmw_manage_secrets_pullsecret_content: >
       {"auths":{"fake":{"auth": "Zm9vOmJhcgo="}}}

roles/rhol_crc/molecule/default/prepare.yml

@@ -18,7 +18,6 @@
 - name: Prepare
   hosts: all
   vars:
-    ansible_user_dir: "{{ lookup('env', 'HOME') }}"
     cifmw_basedir: "{{ ansible_user_dir }}/ci-framework-data"
     async_duration: 6000
   tasks:

roles/rhol_crc/molecule/find_crc/cleanup.yml

@@ -18,7 +18,6 @@
 - name: Prepare
   hosts: all
   vars:
-    ansible_user_dir: "{{ lookup('env', 'HOME') }}"
     cifmw_path: "{{ ansible_user_dir }}/.crc/bin:{{ ansible_user_dir }}/.crc/bin/oc:{{ ansible_user_dir }}/bin:{{ ansible_env.PATH }}"
   tasks:
     - name: Cleanup RHOL/CRC after tests

roles/rhol_crc/molecule/get_versions/cleanup.yml

@@ -18,7 +18,6 @@
 - name: Prepare
   hosts: all
   vars:
-    ansible_user_dir: "{{ lookup('env', 'HOME') }}"
     cifmw_path: "{{ ansible_user_dir }}/.crc/bin:{{ ansible_user_dir }}/.crc/bin/oc:{{ ansible_user_dir }}/bin:{{ ansible_env.PATH }}"
   tasks:
     - name: Cleanup RHOL/CRC after tests