[hooks] Changes after reviewer feedback in draft pr

Reviewer feedback concerns addressed.
Lucas:
    Removed manual OpenShift Lightspeed installation
Lukasz:
    Changed namespace to openshift-lightspeed
    Added configurable host support via cifmw_target_hook_host variable (not localhost anymore)
    Changed operator readiness check from Deployment to CSV status (better for  OLM-based validation)
    Removed metrics-client-ca since we are not longer manually installing OpenShift Lightspeed

Signed-off-by: Malinga Tembo <mtembo@redhat.com>

Author: malingatembo

hooks/playbooks/install-openstack-lightspeed.yml

@@ -1,15 +1,12 @@
 ---
 
-- name: Deploy OpenStack Lightspeed operators
-  hosts: localhost
+- name: Deploy OpenStack Lightspeed operator
+  hosts: "{{ cifmw_target_hook_host | default('localhost') }}"
   connection: local
   vars:
-    # OpenShift Lightspeed (foundation)
-    openshift_lightspeed_namespace: "{{ cifmw_openshift_lightspeed_namespace | default('openshift-lightspeed') }}"
-    openshift_lightspeed_operator_group: "{{ cifmw_openshift_lightspeed_operator_group | default('lightspeed-operator-group') }}"
-
-    # OpenStack Lightspeed (main goal)
-    openstack_lightspeed_namespace: "{{ cifmw_openstack_lightspeed_namespace | default('openstack-lightspeed') }}"
+    # OpenStack Lightspeed configuration
+    # Note: Installing in openshift-lightspeed namespace to ensure compatibility
+    openstack_lightspeed_namespace: "{{ cifmw_openstack_lightspeed_namespace | default('openshift-lightspeed') }}"
     openstack_lightspeed_operator_group: "{{ cifmw_openstack_lightspeed_operator_group | default('openstack-lightspeed-operator-group') }}"
     openstack_lightspeed_catalog_image: "{{ cifmw_openstack_lightspeed_catalog_image | default('quay.io/openstack-lightspeed/operator-catalog:latest') }}"
     openstack_lightspeed_catalog_name: "{{ cifmw_openstack_lightspeed_catalog_name | default('openstack-lightspeed-catalog') }}"
@@ -20,85 +17,7 @@
     KUBECONFIG: "{{ cifmw_openshift_kubeconfig }}"
 
   tasks:
-    # STEP 1: Deploy OpenShift Lightspeed (foundation )
-
-    - name: Create namespace for OpenShift Lightspeed
-      kubernetes.core.k8s:
-        state: present
-        definition:
-          apiVersion: v1
-          kind: Namespace
-          metadata:
-            name: "{{ openshift_lightspeed_namespace }}"
-
-    - name: Get service-ca bundle
-      kubernetes.core.k8s_info:
-        api_version: v1
-        kind: ConfigMap
-        name: service-ca
-        namespace: openshift-config-managed
-      register: service_ca_cm
-
-    - name: Create metrics-client-ca ConfigMap for OpenShift Lightspeed
-      kubernetes.core.k8s:
-        state: present
-        definition:
-          apiVersion: v1
-          kind: ConfigMap
-          metadata:
-            name: metrics-client-ca
-            namespace: openshift-monitoring
-          data:
-            client-ca.crt: "{{ service_ca_cm.resources[0].data['ca-bundle.crt'] }}"
-      when: service_ca_cm.resources | length > 0
-
-    - name: Create OperatorGroup for OpenShift Lightspeed
-      kubernetes.core.k8s:
-        state: present
-        definition:
-          apiVersion: operators.coreos.com/v1
-          kind: OperatorGroup
-          metadata:
-            name: "{{ openshift_lightspeed_operator_group }}"
-            namespace: "{{ openshift_lightspeed_namespace }}"
-          spec:
-            targetNamespaces:
-              - "{{ openshift_lightspeed_namespace }}"
-
-    - name: Subscribe to OpenShift Lightspeed operator
-      kubernetes.core.k8s:
-        state: present
-        definition:
-          apiVersion: operators.coreos.com/v1alpha1
-          kind: Subscription
-          metadata:
-            name: "lightspeed-operator"
-            namespace: "{{ openshift_lightspeed_namespace }}"
-          spec:
-            channel: "stable"
-            name: "lightspeed-operator"
-            source: "redhat-operators"
-            sourceNamespace: "openshift-marketplace"
-            installPlanApproval: "Automatic"
-
-    - name: Wait for OpenShift Lightspeed operator to be ready
-      kubernetes.core.k8s_info:
-        api_version: apps/v1
-        kind: Deployment
-        namespace: "{{ openshift_lightspeed_namespace }}"
-        label_selectors:
-          - "control-plane=controller-manager"
-      register: ols_deployment
-      failed_when: false
-      until:
-        - ols_deployment.resources is defined
-        - ols_deployment.resources | length > 0
-        - ols_deployment.resources[0].status.readyReplicas is defined
-        - ols_deployment.resources[0].status.readyReplicas > 0
-      retries: 30
-      delay: 10
-
-    # STEP 2: Deploy OpenStack Lightspeed catalog
+    # STEP 1: Deploy OpenStack Lightspeed catalog
 
     - name: Create CatalogSource for OpenStack Lightspeed
       kubernetes.core.k8s:
@@ -131,7 +50,9 @@
       retries: 30
       delay: 10
 
-    # STEP 3: Deploy OpenStack Lightspeed operator
+    # STEP 2: Deploy OpenStack Lightspeed operator
+    # Note: OpenStack Lightspeed operator will automatically install
+    # and manage the OpenShift Lightspeed operator as a dependency
 
     - name: Create namespace for OpenStack Lightspeed
       kubernetes.core.k8s:
@@ -171,25 +92,25 @@
             sourceNamespace: "openshift-marketplace"
             installPlanApproval: "Automatic"
 
-    - name: Wait for OpenStack Lightspeed operator to be ready
+    - name: Wait for OpenStack Lightspeed CSV to be ready
       kubernetes.core.k8s_info:
-        api_version: apps/v1
-        kind: Deployment
+        api_version: operators.coreos.com/v1alpha1
+        kind: ClusterServiceVersion
         namespace: "{{ openstack_lightspeed_namespace }}"
         label_selectors:
-          - "control-plane=controller-manager"
-      register: osls_deployment
+          - "operators.coreos.com/openstack-lightspeed-operator.{{ openstack_lightspeed_namespace }}"
+      register: osls_csv
       failed_when: false
       until:
-        - osls_deployment.resources is defined
-        - osls_deployment.resources | length > 0
-        - osls_deployment.resources[0].status.readyReplicas is defined
-        - osls_deployment.resources[0].status.readyReplicas > 0
+        - osls_csv.resources is defined
+        - osls_csv.resources | length > 0
+        - osls_csv.resources[0].status.phase is defined
+        - osls_csv.resources[0].status.phase == "Succeeded"
       retries: 30
       delay: 10
 
     - name: Display deployment summary
       ansible.builtin.debug:
         msg:
-          - "✓ OpenShift Lightspeed operator deployed in namespace: {{ openshift_lightspeed_namespace }}"
           - "✓ OpenStack Lightspeed operator deployed in namespace: {{ openstack_lightspeed_namespace }}"
+          - "✓ OpenShift Lightspeed operator will be automatically managed by OpenStack Lightspeed"