Fix BGP registry IP route collection for multi-datacenter deployments

The original implementation attempted to run getent directly in the task
with delegate_to using an undefined loop variable, causing task failures.

This fix properly delegates getent execution to each overcloud VM and
accumulates the resolved IPs across all VMs. This is necessary because
VMs in different racks/datacenters may use different DNS servers, resulting
in different IP resolutions for the same registry domains.

Changes:
- Extract getent logic into separate task file (getent_registry_ips_bgp.yml)
- Run getent from each VM via include_tasks with proper delegation
- Accumulate IPs using set_fact to preserve results across all VMs
- Simplify IP list generation in both prepare_overcloud.yml and
  prepare_undercloud.yml to use the accumulated list

The accumulated IP list ensures routes are added for all possible registry
IPs as resolved from each datacenter's DNS server.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: eduolivares

roles/adoption_osp_deploy/tasks/getent_registry_ips_bgp.yml

@@ -0,0 +1,42 @@
+---
+# Copyright Red Hat, Inc.
+# All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may
+# not use this file except in compliance with the License. You may obtain
+# a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+
+- name: Obtain IPs whose routes need to be added to the undercloud (bgp)
+  ansible.builtin.getent:
+    database: ahosts
+    key: "{{ item }}"
+  register: _current_vm_getent
+  loop:
+    - registry.redhat.io
+    - cdn.redhat.com
+    - access.redhat.com
+    - cdn01.quay.io
+
+- name: Accumulate IPs from this VM
+  ansible.builtin.set_fact:
+    _accumulated_ips: >-
+      {{
+        _accumulated_ips | default([]) +
+        (
+          _current_vm_getent.results |
+          map(attribute='ansible_facts.getent_ahosts') |
+          map('dict2items') |
+          flatten |
+          map(attribute='key') |
+          reject('match', '.*:.*') |
+          list
+        )
+      }}

roles/adoption_osp_deploy/tasks/prepare_overcloud.yml

@@ -197,16 +197,14 @@
 
     - name: Obtain IPs whose routes need to be added to the undercloud (bgp)
       when: bgp
-      delegate_to: "{{ overcloud_vm }}"
-      ansible.builtin.getent:
-        database: ahosts
-        key: "{{ item }}"
-      register: _ips_for_oc_routes_getent
-      loop:
-        - registry.redhat.io
-        - cdn.redhat.com
-        - access.redhat.com
-        - cdn01.quay.io
+      ansible.builtin.include_tasks: getent_registry_ips_bgp.yml
+      args:
+        apply:
+          delegate_to: "{{ _vm }}"
+      loop: "{{ _tripleo_nodes_stack[_overcloud_name] }}"
+      loop_control:
+        loop_var: _vm
+        pause: 1
 
     - name: Generate os-net-config file for overcloud nodes (bgp)
       become: true
@@ -215,17 +213,7 @@
         _node_net: "{{ cifmw_networking_env_definition.instances[overcloud_vm] }}"
         _dns_server: "{{ _ctlplane_net.[dns_version|default('dns_v4')] }}"
         _interface_mtu: 1500
-        _ips_for_oc_routes_list: >-
-          {{
-            _ips_for_oc_routes_getent.results |
-            map(attribute='ansible_facts.getent_ahosts') |
-            map('dict2items') |
-            flatten |
-            map(attribute='key') |
-            reject('match', '.*:.*') |
-            list |
-            unique
-          }}
+        _ips_for_oc_routes_list: "{{ _accumulated_ips | unique }}"
         vms:
           osp-r0-compute-0:
             ctlplane: '192.168.122.100'

roles/adoption_osp_deploy/tasks/prepare_undercloud.yml

@@ -128,15 +128,7 @@
 
     - name: Obtain IPs whose routes need to be added to the undercloud (bgp)
       when: bgp
-      ansible.builtin.getent:
-        database: ahosts
-        key: "{{ item }}"
-      register: _ips_for_uc_routes_getent
-      loop:
-        - registry.redhat.io
-        - cdn.redhat.com
-        - access.redhat.com
-        - cdn01.quay.io
+      ansible.builtin.include_tasks: getent_registry_ips_bgp.yml
 
     - name: Generate os-net-config file (bgp)
       when: bgp
@@ -151,17 +143,7 @@
         _gateway_ip: "{{ _ctlplane_net[gw_version|default('gw_v4')] }}"
         _interface_mtu: "{{ _undercloud_net.networks.ctlplaner0.mtu }}"
         _ctlplane_cidr: "{{ _undercloud_net.networks.ctlplaner0[prefix_length_version|default('prefix_length_v4')] }}"
-        _ips_for_uc_routes_list: >-
-          {{
-            _ips_for_uc_routes_getent.results |
-            map(attribute='ansible_facts.getent_ahosts') |
-            map('dict2items') |
-            flatten |
-            map(attribute='key') |
-            reject('match', '.*:.*') |
-            list |
-            unique
-          }}
+        _ips_for_uc_routes_list: "{{ _accumulated_ips | unique }}"
       ansible.builtin.template:
         src: "os_net_config_undercloud_bgp.yml.j2"
         dest: /etc/os-net-config/tripleo_config.yaml

roles/adoption_osp_deploy/templates/os_net_config_overcloud_bgp.yml.j2

@@ -6,6 +6,10 @@ network_config:
   use_dhcp: true
   defroute: false
   routes:
+  - ip_netmask: 10.0.0.0/8
+    next_hop: 192.168.111.1
+  - ip_netmask: 23.0.0.0/8
+    next_hop: 192.168.111.1
 {% for _ip in _ips_for_oc_routes_list %}
   - ip_netmask: {{ _ip }}/32
     next_hop: 192.168.111.1