Exclude roles symlink from ansibe-lint

Some files in roles dir are excluded from lint check. Adding roles dir symlink in hooks dir is causing lint to check those files too, causing lint job to fail. Excluding that symlink should help.

Signed-off-by: Amartya Sinha <[email protected]>
Co-Authored-By: Daniel Pawlik <[email protected]>

Author: amartyasinha

.ansible-lint

@@ -22,6 +22,7 @@ exclude_paths:
   - roles/kustomize_deploy/molecule/flexible_loop/prepare.yml  # import_playbook
   - roles/*/molecule/*/side_effect.yml  # syntax-check[empty-playbook] https://github.com/ansible/molecule/issues/3617
   - roles/ci_multus/molecule/*/nads_output.yml # internal-error due to "---" characters
+  - hooks/playbooks/roles/
 strict: true
 quiet: false
 verbosity: 1

roles/pcp_metrics/tasks/annotations.yaml

@@ -21,12 +21,13 @@
   register: _annotations_shell
 
 - name: Ensure the output directory exist
-  file:
+  ansible.builtin.file:
     path: "{{ pcp_metrics_output_dir }}"
     state: directory
     mode: '0755'
 
 - name: Save annotations
-  copy:
+  ansible.builtin.copy:
     content: "{{ _annotations_shell.stdout }}"
     dest: "{{ pcp_metrics_output_dir }}/annotations.txt"
+    mode: "0644"

roles/pcp_metrics/tasks/coreos.yaml

@@ -17,15 +17,15 @@
         name: baseos
         description: BaseOS repository
         baseurl: "{{ pcp_repo_url }}/BaseOS/$basearch/os/"
-        gpgcheck: no
+        gpgcheck: false
 
     - name: Set repositories (AppStream)
       ansible.builtin.yum_repository:
         file: pcp-coreos-hack
         name: appstream
         description: AppStream repository
         baseurl: "{{ pcp_repo_url }}/AppStream/$basearch/os/"
-        gpgcheck: no
+        gpgcheck: false
 
 - name: Make /usr writable
   become: true
@@ -39,3 +39,4 @@
   ansible.builtin.file:
     path: /var/lib/rpm-state
     state: directory
+    mode: "0750"

roles/pcp_metrics/tasks/gather.yaml

@@ -21,7 +21,7 @@
   register: _pmrep
 
 - name: Check if archive exists
-  stat:
+  ansible.builtin.stat:
     path: "{{ pcp_metrics_archive }}"
   register: _pcp_archive
 
@@ -47,14 +47,15 @@
       changed_when: false
 
     - name: Ensure the output directory exist
-      file:
+      ansible.builtin.file:
         path: "{{ pcp_metrics_output_dir }}"
         state: directory
         mode: '0755'
       delegate_to: localhost
 
     - name: Save the collected metrics to a local file
-      copy:
+      ansible.builtin.copy:
         content: "{{ _pcp_metrics_pmrep.stdout }}"
         dest: "{{ pcp_metrics_output_dir }}/{{ ansible_hostname }}.csv"
+        mode: "0644"
       delegate_to: localhost